Modified: trunk/Websites/test-results/ChangeLog (158584 => 158585)
--- trunk/Websites/test-results/ChangeLog 2013-11-04 20:12:22 UTC (rev 158584)
+++ trunk/Websites/test-results/ChangeLog 2013-11-04 20:15:08 UTC (rev 158585)
@@ -1,5 +1,12 @@
2013-11-04 Ryosuke Niwa <[email protected]>
+ Build fixes. In particular, we were missing the code to generate JSONs in report.php :(
+
+ * public/api/report.php:
+ * public/include/test-results.php:
+
+2013-11-04 Ryosuke Niwa <[email protected]>
+
Fix JSON generations on new flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123723
Modified: trunk/Websites/test-results/public/api/report.php (158584 => 158585)
--- trunk/Websites/test-results/public/api/report.php 2013-11-04 20:12:22 UTC (rev 158584)
+++ trunk/Websites/test-results/public/api/report.php 2013-11-04 20:15:08 UTC (rev 158585)
@@ -34,7 +34,7 @@
if (!store_test_results($db, $test_results, $build_id, $start_time, $end_time, $slave_id))
exit_with_error('FailedToStoreResults', array('buildId' => $build_id));
- return $build_id;
+ return array('build_id' => $build_id, 'builder_id' => $builder_id);
}
function main() {
@@ -66,7 +66,7 @@
$json_path = $_FILES['file']['tmp_name'];
$db = connect();
- $build_id = store_results($db, $master, $builder_name, $build_number, $start_time, $end_time, $revisions, $json_path);
+ $builder_and_build = store_results($db, $master, $builder_name, $build_number, $start_time, $end_time, $revisions, $json_path);
@ob_end_clean();
ignore_user_abort();
ob_start();
@@ -81,7 +81,11 @@
if (function_exists('fastcgi_finish_request'))
fastcgi_finish_request();
- update_flakiness_after_inserting_build($build_id);
+ update_flakiness_after_inserting_build($db, $builder_and_build['build_id']);
+
+ $generator = new ResultsJSONGenerator($db, $builder_and_build['builder_id']);
+ $generator->generate('wrongexpectations');
+ $generator->generate('flaky');
}
main();
Modified: trunk/Websites/test-results/public/include/test-results.php (158584 => 158585)
--- trunk/Websites/test-results/public/include/test-results.php 2013-11-04 20:12:22 UTC (rev 158584)
+++ trunk/Websites/test-results/public/include/test-results.php 2013-11-04 20:15:08 UTC (rev 158585)
@@ -171,7 +171,7 @@
}
if (!$test_rows)
- return FALSE;
+ return TRUE;
$comma_separated_test_ids = '';
foreach ($test_rows as $row) {
