Title: [158808] trunk/Source/WebKit2
- Revision
- 158808
- Author
- [email protected]
- Date
- 2013-11-06 18:02:14 -0800 (Wed, 06 Nov 2013)
Log Message
Remote Layer Tree: RemoteLayerTreeDrawingArea doesn't make layers for fixedpos elements
https://bugs.webkit.org/show_bug.cgi?id=123943
Reviewed by Simon Fraser.
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Make fixed position elements create compositing layers and stacking contexts
in the RemoteLayerTreeDrawingArea just like they do in TiledCoreAnimationDrawingArea.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
Fix the comment, since we have long since achieved this goal.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (158807 => 158808)
--- trunk/Source/WebKit2/ChangeLog 2013-11-07 01:41:27 UTC (rev 158807)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-07 02:02:14 UTC (rev 158808)
@@ -1,3 +1,20 @@
+2013-11-06 Tim Horton <[email protected]>
+
+ Remote Layer Tree: RemoteLayerTreeDrawingArea doesn't make layers for fixedpos elements
+ https://bugs.webkit.org/show_bug.cgi?id=123943
+
+ Reviewed by Simon Fraser.
+
+ * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
+ * WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
+ (WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
+ Make fixed position elements create compositing layers and stacking contexts
+ in the RemoteLayerTreeDrawingArea just like they do in TiledCoreAnimationDrawingArea.
+
+ * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+ (WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
+ Fix the comment, since we have long since achieved this goal.
+
2013-11-06 Anders Carlsson <[email protected]>
Implement enough functionality so that NSURLRequest objects can be decoded
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h (158807 => 158808)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h 2013-11-07 01:41:27 UTC (rev 158807)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h 2013-11-07 02:02:14 UTC (rev 158808)
@@ -50,6 +50,8 @@
virtual bool shouldUseTiledBackingForFrameView(const WebCore::FrameView*) OVERRIDE;
+ virtual void updatePreferences(const WebPreferencesStore&) OVERRIDE;
+
std::unique_ptr<RemoteLayerTreeContext> m_remoteLayerTreeContext;
};
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm (158807 => 158808)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm 2013-11-07 01:41:27 UTC (rev 158807)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm 2013-11-07 02:02:14 UTC (rev 158808)
@@ -89,4 +89,14 @@
return frameView && frameView->frame().isMainFrame();
}
+void RemoteLayerTreeDrawingArea::updatePreferences(const WebPreferencesStore&)
+{
+ Settings& settings = m_webPage->corePage()->settings();
+
+ // Fixed position elements need to be composited and create stacking contexts
+ // in order to be scrolled by the ScrollingCoordinator.
+ settings.setAcceleratedCompositingForFixedPositionEnabled(true);
+ settings.setFixedPositionCreatesStackingContext(true);
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (158807 => 158808)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2013-11-07 01:41:27 UTC (rev 158807)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2013-11-07 02:02:14 UTC (rev 158808)
@@ -251,9 +251,8 @@
it->value->setShowRepaintCounter(settings.showRepaintCounter());
}
- // Soon we want pages with fixed positioned elements to be able to be scrolled by the ScrollingCoordinator.
- // As a part of that work, we have to composite fixed position elements, and we have to allow those
- // elements to create a stacking context.
+ // Fixed position elements need to be composited and create stacking contexts
+ // in order to be scrolled by the ScrollingCoordinator.
settings.setAcceleratedCompositingForFixedPositionEnabled(true);
settings.setFixedPositionCreatesStackingContext(true);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
