Title: [158816] trunk/Source/WebInspectorUI
- Revision
- 158816
- Author
- [email protected]
- Date
- 2013-11-06 19:49:36 -0800 (Wed, 06 Nov 2013)
Log Message
Properly null check positionToReveal in ResourceSidebarPanel.prototype.showSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=123921
Reviewed by Joseph Pecoraro.
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (158815 => 158816)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-11-07 03:49:36 UTC (rev 158815)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-11-07 03:49:36 UTC (rev 158816)
@@ -1,5 +1,16 @@
2013-11-06 Timothy Hatcher <[email protected]>
+ Properly null check positionToReveal in ResourceSidebarPanel.prototype.showSourceCode.
+
+ https://bugs.webkit.org/show_bug.cgi?id=123921
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/ResourceSidebarPanel.js:
+ (WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
+
+2013-11-06 Timothy Hatcher <[email protected]>
+
Fix the display of query parameters when the value is missing.
https://bugs.webkit.org/show_bug.cgi?id=123920
Modified: trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js (158815 => 158816)
--- trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js 2013-11-07 03:49:36 UTC (rev 158815)
+++ trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js 2013-11-07 03:49:36 UTC (rev 158816)
@@ -151,7 +151,7 @@
representedObject = representedObject.parentFrame;
var newContentView = WebInspector.contentBrowser.contentViewForRepresentedObject(representedObject);
- var cookie = {lineNumber: positionToReveal.lineNumber, columnNumber: positionToReveal.columnNumber};
+ var cookie = positionToReveal ? {lineNumber: positionToReveal.lineNumber, columnNumber: positionToReveal.columnNumber} : {};
WebInspector.contentBrowser.showContentView(newContentView, cookie);
},
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
