Title: [158829] trunk/Source/WebCore
- Revision
- 158829
- Author
- [email protected]
- Date
- 2013-11-07 01:32:57 -0800 (Thu, 07 Nov 2013)
Log Message
Simplify Attr by removing m_specified member variable and setter
https://bugs.webkit.org/show_bug.cgi?id=123965
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/597f44ec928e08820574728889adabc6d8ecd746
m_specified is always true in WebKit so simply return true in Attr::specified().
* dom/Attr.cpp:
(WebCore::Attr::Attr):
* dom/Attr.h:
* dom/Document.cpp:
(WebCore::Document::adoptNode):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (158828 => 158829)
--- trunk/Source/WebCore/ChangeLog 2013-11-07 09:21:08 UTC (rev 158828)
+++ trunk/Source/WebCore/ChangeLog 2013-11-07 09:32:57 UTC (rev 158829)
@@ -1,3 +1,20 @@
+2013-11-07 Ryosuke Niwa <[email protected]>
+
+ Simplify Attr by removing m_specified member variable and setter
+ https://bugs.webkit.org/show_bug.cgi?id=123965
+
+ Reviewed by Andreas Kling.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/597f44ec928e08820574728889adabc6d8ecd746
+
+ m_specified is always true in WebKit so simply return true in Attr::specified().
+
+ * dom/Attr.cpp:
+ (WebCore::Attr::Attr):
+ * dom/Attr.h:
+ * dom/Document.cpp:
+ (WebCore::Document::adoptNode):
+
2013-10-25 Jer Noble <[email protected]>
[MSE] Add MediaSource extensions to AudioTrack, VideoTrack, and TextTrack.
Modified: trunk/Source/WebCore/dom/Attr.cpp (158828 => 158829)
--- trunk/Source/WebCore/dom/Attr.cpp 2013-11-07 09:21:08 UTC (rev 158828)
+++ trunk/Source/WebCore/dom/Attr.cpp 2013-11-07 09:32:57 UTC (rev 158829)
@@ -41,7 +41,6 @@
, m_element(element)
, m_name(name)
, m_ignoreChildrenChanged(0)
- , m_specified(true)
{
}
@@ -51,7 +50,6 @@
, m_name(name)
, m_standaloneValue(standaloneValue)
, m_ignoreChildrenChanged(0)
- , m_specified(true)
{
}
Modified: trunk/Source/WebCore/dom/Attr.h (158828 => 158829)
--- trunk/Source/WebCore/dom/Attr.h 2013-11-07 09:21:08 UTC (rev 158828)
+++ trunk/Source/WebCore/dom/Attr.h 2013-11-07 09:32:57 UTC (rev 158829)
@@ -46,7 +46,7 @@
virtual ~Attr();
String name() const { return qualifiedName().toString(); }
- bool specified() const { return m_specified; }
+ bool specified() const { return true; }
Element* ownerElement() const { return m_element; }
const AtomicString& value() const;
@@ -59,8 +59,6 @@
CSSStyleDeclaration* style();
- void setSpecified(bool specified) { m_specified = specified; }
-
void attachToElement(Element*);
void detachFromElementWithValue(const AtomicString&);
@@ -98,8 +96,7 @@
AtomicString m_standaloneValue;
RefPtr<MutableStylePropertySet> m_style;
- unsigned m_ignoreChildrenChanged : 31;
- bool m_specified : 1;
+ unsigned m_ignoreChildrenChanged;
};
inline bool isAttr(const Node& node) { return node.isAttributeNode(); }
Modified: trunk/Source/WebCore/dom/Document.cpp (158828 => 158829)
--- trunk/Source/WebCore/dom/Document.cpp 2013-11-07 09:21:08 UTC (rev 158828)
+++ trunk/Source/WebCore/dom/Document.cpp 2013-11-07 09:32:57 UTC (rev 158829)
@@ -970,7 +970,6 @@
Attr& attr = toAttr(*source);
if (attr.ownerElement())
attr.ownerElement()->removeAttributeNode(&attr, ec);
- attr.setSpecified(true);
break;
}
default:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
