Title: [158869] trunk/Source/WebCore
- Revision
- 158869
- Author
- [email protected]
- Date
- 2013-11-07 13:43:22 -0800 (Thu, 07 Nov 2013)
Log Message
[Mac] Crash at com.apple.WebCore: -[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:] + 2084
https://bugs.webkit.org/show_bug.cgi?id=124012
Reviewed by Eric Carlson.
The value of the 'duration' key is a NSConcreteValue wrapping a CMTime, not a NSNumber.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (158868 => 158869)
--- trunk/Source/WebCore/ChangeLog 2013-11-07 21:39:49 UTC (rev 158868)
+++ trunk/Source/WebCore/ChangeLog 2013-11-07 21:43:22 UTC (rev 158869)
@@ -1,3 +1,15 @@
+2013-11-07 Jer Noble <[email protected]>
+
+ [Mac] Crash at com.apple.WebCore: -[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:] + 2084
+ https://bugs.webkit.org/show_bug.cgi?id=124012
+
+ Reviewed by Eric Carlson.
+
+ The value of the 'duration' key is a NSConcreteValue wrapping a CMTime, not a NSNumber.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
+
2013-11-07 Ryosuke Niwa <[email protected]>
Crash when submitting form in a document with null encoding
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (158868 => 158869)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2013-11-07 21:39:49 UTC (rev 158868)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2013-11-07 21:43:22 UTC (rev 158869)
@@ -1888,7 +1888,7 @@
else if ([keyPath isEqualToString:@"presentationSize"])
function = WTF::bind(&MediaPlayerPrivateAVFoundationObjC::presentationSizeDidChange, m_callback, FloatSize([newValue sizeValue]));
else if ([keyPath isEqualToString:@"duration"])
- function = WTF::bind(&MediaPlayerPrivateAVFoundationObjC::durationDidChange, m_callback, [newValue doubleValue]);
+ function = WTF::bind(&MediaPlayerPrivateAVFoundationObjC::durationDidChange, m_callback, CMTimeGetSeconds([newValue CMTimeValue]));
}
if (context == MediaPlayerAVFoundationObservationContextPlayer && !willChange) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
