Title: [158880] trunk/Source/WebKit2
Revision
158880
Author
[email protected]
Date
2013-11-07 15:31:08 -0800 (Thu, 07 Nov 2013)

Log Message

Remove more dead code
https://bugs.webkit.org/show_bug.cgi?id=124016

Reviewed by Beth Dakin.

We're always layer backed now so we never scroll using the PageClient.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::canScrollView):
(WebKit::PageClientImpl::scrollView):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (158879 => 158880)


--- trunk/Source/WebKit2/ChangeLog	2013-11-07 23:26:35 UTC (rev 158879)
+++ trunk/Source/WebKit2/ChangeLog	2013-11-07 23:31:08 UTC (rev 158880)
@@ -1,5 +1,18 @@
 2013-11-07  Anders Carlsson  <[email protected]>
 
+        Remove more dead code
+        https://bugs.webkit.org/show_bug.cgi?id=124016
+
+        Reviewed by Beth Dakin.
+
+        We're always layer backed now so we never scroll using the PageClient.
+
+        * UIProcess/API/mac/PageClientImpl.mm:
+        (WebKit::PageClientImpl::canScrollView):
+        (WebKit::PageClientImpl::scrollView):
+
+2013-11-07  Anders Carlsson  <[email protected]>
+
         Don't repaint the view when the web process crashes
         https://bugs.webkit.org/show_bug.cgi?id=124013
 

Modified: trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm (158879 => 158880)


--- trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm	2013-11-07 23:26:35 UTC (rev 158879)
+++ trunk/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm	2013-11-07 23:31:08 UTC (rev 158880)
@@ -150,18 +150,12 @@
 
 bool PageClientImpl::canScrollView()
 {
-    // -scrollRect:by: does nothing in layer-backed views <rdar://problem/12961719>.
-    return ![m_wkView layer];
+    return false;
 }
 
 void PageClientImpl::scrollView(const IntRect& scrollRect, const IntSize& scrollOffset)
 {
-    NSRect clippedScrollRect = NSIntersectionRect(scrollRect, NSOffsetRect(scrollRect, -scrollOffset.width(), -scrollOffset.height()));
-
-    [m_wkView _cacheWindowBottomCornerRect];
-
-    [m_wkView translateRectsNeedingDisplayInRect:clippedScrollRect by:scrollOffset];
-    [m_wkView scrollRect:clippedScrollRect by:scrollOffset];
+    ASSERT_NOT_REACHED();
 }
 
 IntSize PageClientImpl::viewSize()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to