Title: [158913] trunk
- Revision
- 158913
- Author
- [email protected]
- Date
- 2013-11-08 02:24:39 -0800 (Fri, 08 Nov 2013)
Log Message
[GTK] accessibility/aria-link-supports-press.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98355
Patch by Krzysztof Czech <[email protected]> on 2013-11-08
Reviewed by Mario Sanchez Prada.
Tools:
Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isPressActionSupported):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):
LayoutTests:
Removed failure expectation.
* platform/gtk/TestExpectations: test is no longer failing.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (158912 => 158913)
--- trunk/LayoutTests/ChangeLog 2013-11-08 09:43:44 UTC (rev 158912)
+++ trunk/LayoutTests/ChangeLog 2013-11-08 10:24:39 UTC (rev 158913)
@@ -1,3 +1,14 @@
+2013-11-08 Krzysztof Czech <[email protected]>
+
+ [GTK] accessibility/aria-link-supports-press.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=98355
+
+ Reviewed by Mario Sanchez Prada.
+
+ Removed failure expectation.
+
+ * platform/gtk/TestExpectations: test is no longer failing.
+
2013-11-08 Andreas Kling <[email protected]>
Add back expectation for test that went missing in r158813.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (158912 => 158913)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-08 09:43:44 UTC (rev 158912)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-11-08 10:24:39 UTC (rev 158913)
@@ -875,7 +875,6 @@
webkit.org/b/79757 fast/selectors/selection-window-inactive.html [ ImageOnlyFailure ]
webkit.org/b/121684 accessibility/aria-describedby-on-input.html [ Failure ]
-webkit.org/b/98355 accessibility/aria-link-supports-press.html [ Failure ]
webkit.org/b/98357 accessibility/aria-readonly.html [ Failure ]
webkit.org/b/98359 accessibility/aria-text-role.html [ Failure ]
webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
Modified: trunk/Tools/ChangeLog (158912 => 158913)
--- trunk/Tools/ChangeLog 2013-11-08 09:43:44 UTC (rev 158912)
+++ trunk/Tools/ChangeLog 2013-11-08 10:24:39 UTC (rev 158913)
@@ -1,3 +1,18 @@
+2013-11-08 Krzysztof Czech <[email protected]>
+
+ [GTK] accessibility/aria-link-supports-press.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=98355
+
+ Reviewed by Mario Sanchez Prada.
+
+ Checking "jump" action for link elements. Action "jump" occurs when a link
+ element is pressed/clicked.
+
+ * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+ (AccessibilityUIElement::isPressActionSupported):
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::AccessibilityUIElement::isPressActionSupported):
+
2013-11-08 Przemyslaw Szymanski <[email protected]>
[JHBUILD] Jhbuild Makefile build bug workaround
Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (158912 => 158913)
--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-11-08 09:43:44 UTC (rev 158912)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp 2013-11-08 10:24:39 UTC (rev 158913)
@@ -907,7 +907,8 @@
if (!ATK_IS_ACTION(m_element))
return false;
- return equalIgnoringCase(atk_action_get_name(ATK_ACTION(m_element), 0), String("press"));
+ const gchar* actionName = atk_action_get_name(ATK_ACTION(m_element), 0);
+ return equalIgnoringCase(actionName, String("press")) || equalIgnoringCase(actionName, String("jump"));
}
bool AccessibilityUIElement::isIncrementActionSupported()
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (158912 => 158913)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-11-08 09:43:44 UTC (rev 158912)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-11-08 10:24:39 UTC (rev 158913)
@@ -1010,7 +1010,8 @@
if (!ATK_IS_ACTION(m_element.get()))
return false;
- return equalIgnoringCase(atk_action_get_name(ATK_ACTION(m_element.get()), 0), String("press"));
+ const gchar* actionName = atk_action_get_name(ATK_ACTION(m_element.get()), 0);
+ return equalIgnoringCase(actionName, String("press")) || equalIgnoringCase(actionName, String("jump"));
}
bool AccessibilityUIElement::isIncrementActionSupported()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
