Diff
Modified: trunk/LayoutTests/ChangeLog (158990 => 158991)
--- trunk/LayoutTests/ChangeLog 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/ChangeLog 2013-11-09 06:00:50 UTC (rev 158991)
@@ -1,5 +1,26 @@
2013-11-08 Thiago de Barros Lacerda <[email protected]>
+ Updating LayoutTests that depend on RTCPeerConnection
+ https://bugs.webkit.org/show_bug.cgi?id=124097
+
+ Reviewed by Eric Carlson.
+
+ Needed to do not throw unwanted exception
+
+ * fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
+ * fast/mediastream/RTCPeerConnection-createAnswer.html:
+ * fast/mediastream/RTCPeerConnection-createOffer.html:
+ * fast/mediastream/RTCPeerConnection-datachannel.html:
+ * fast/mediastream/RTCPeerConnection-dtmf.html:
+ * fast/mediastream/RTCPeerConnection-events.html:
+ * fast/mediastream/RTCPeerConnection-ice.html:
+ * fast/mediastream/RTCPeerConnection-localDescription.html:
+ * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
+ * fast/mediastream/RTCPeerConnection-remoteDescription.html:
+ * fast/mediastream/RTCPeerConnection-state.html:
+
+2013-11-08 Thiago de Barros Lacerda <[email protected]>
+
Improving readability of LayoutTests in fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=124095
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-AddRemoveStream.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -60,7 +60,7 @@
shouldBeFalse("stream.id === stream2.id");
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
pc._onnegotiationneeded_ = onAddStream;
pc.addStream(stream);
}
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createAnswer.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -51,7 +51,7 @@
finishJSTest();
}
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
pc.createOffer(requestSucceeded1, requestFailed1);
window.jsTestIsAsync = true;
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -41,7 +41,7 @@
pc.createOffer(requestSucceeded2, requestFailed2, {mandatory:{"succeed":false}});
}
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
pc.createOffer(requestSucceeded1, requestFailed1, {mandatory:{"succeed":true}});
window.jsTestIsAsync = true;
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-datachannel.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-datachannel.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-datachannel.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -81,7 +81,7 @@
}
}
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
shouldNotThrow('dc = pc.createDataChannel("label1");');
shouldNotThrow('dc = pc.createDataChannel("label2", {});');
shouldNotThrow('dc = pc.createDataChannel("label3", {ordered:true});');
@@ -89,7 +89,7 @@
shouldNotThrow('dc = pc.createDataChannel("label3", {maxRetransmits:0});');
shouldNotThrow('dc = pc.createDataChannel("label3", {maxRetransmitTime:0});');
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
pc._oniceconnectionstatechange_ = pc_onicechange;
pc._ondatachannel_ = pc_ondatachannel;
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-dtmf.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -52,7 +52,7 @@
shouldBe('stream.getAudioTracks().length', '1');
shouldBe('stream.getVideoTracks().length', '0');
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
pc._oniceconnectionstatechange_ = pc_onicechange;
}
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-events.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-events.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-events.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -41,7 +41,7 @@
testPassed('gotStream was called.');
stream = s;
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
pc._onnegotiationneeded_ = onNegotiationNeeded;
pc.addStream(stream);
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -43,7 +43,7 @@
}
}
- shouldNotThrow('pc = new webkitRTCPeerConnection({iceServers:[]}, null);');
+ shouldNotThrow('pc = new webkitRTCPeerConnection({iceServers:[]});');
pc._oniceconnectionstatechange_ = onIceChange1;
window.jsTestIsAsync = true;
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-localDescription.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -42,7 +42,7 @@
shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded2, requestFailed2);');
}
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
var sessionDescription = new RTCSessionDescription({type:"offer", sdp:"local"});
shouldNotThrow('pc.setLocalDescription(sessionDescription, requestSucceeded1, requestFailed1);');
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -34,7 +34,7 @@
testPassed('Got a stream.');
stream = s;
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
pc._onnegotiationneeded_ = onNegotiationNeeded;
pc.addStream(stream);
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-remoteDescription.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -42,7 +42,7 @@
shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded2, requestFailed2);');
}
- pc = new webkitRTCPeerConnection({iceServers:[]}, null);
+ pc = new webkitRTCPeerConnection({iceServers:[]});
var sessionDescription = new RTCSessionDescription({type:"answer", sdp:"remote"});
shouldNotThrow('pc.setRemoteDescription(sessionDescription, requestSucceeded1, requestFailed1);');
Modified: trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state.html (158990 => 158991)
--- trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state.html 2013-11-09 04:40:42 UTC (rev 158990)
+++ trunk/LayoutTests/fast/mediastream/RTCPeerConnection-state.html 2013-11-09 06:00:50 UTC (rev 158991)
@@ -16,7 +16,7 @@
finishJSTest();
}
- shouldNotThrow('pc = new webkitRTCPeerConnection({iceServers:[]}, null);');
+ shouldNotThrow('pc = new webkitRTCPeerConnection({iceServers:[]});');
shouldBeEqualToString('pc.signalingState', 'stable');
pc._onsignalingstatechange_ = stateChanged;
pc.close();
