Title: [159051] trunk/Tools
- Revision
- 159051
- Author
- [email protected]
- Date
- 2013-11-11 09:33:19 -0800 (Mon, 11 Nov 2013)
Log Message
Do not shut down ImageDiff server after every diff during the tests.
https://bugs.webkit.org/show_bug.cgi?id=124140
Patch by Tamas Gergely <[email protected]> on 2013-11-11
Reviewed by Csaba Osztrogonác.
There was a FIXME: There is no need to shut down the ImageDiff
server after every diff. Shutdown is removed from that point.
* Scripts/webkitpy/port/image_diff.py:
(ImageDiffer._read):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (159050 => 159051)
--- trunk/Tools/ChangeLog 2013-11-11 17:28:13 UTC (rev 159050)
+++ trunk/Tools/ChangeLog 2013-11-11 17:33:19 UTC (rev 159051)
@@ -1,3 +1,16 @@
+2013-11-11 Tamas Gergely <[email protected]>
+
+ Do not shut down ImageDiff server after every diff during the tests.
+ https://bugs.webkit.org/show_bug.cgi?id=124140
+
+ Reviewed by Csaba Osztrogonác.
+
+ There was a FIXME: There is no need to shut down the ImageDiff
+ server after every diff. Shutdown is removed from that point.
+
+ * Scripts/webkitpy/port/image_diff.py:
+ (ImageDiffer._read):
+
2013-11-08 Matthew Hanson <[email protected]>
Unreviewed. Added myself as a contributor.
Modified: trunk/Tools/Scripts/webkitpy/port/image_diff.py (159050 => 159051)
--- trunk/Tools/Scripts/webkitpy/port/image_diff.py 2013-11-11 17:28:13 UTC (rev 159050)
+++ trunk/Tools/Scripts/webkitpy/port/image_diff.py 2013-11-11 17:33:19 UTC (rev 159051)
@@ -100,9 +100,6 @@
if self._process.has_crashed():
err_str += "ImageDiff crashed\n"
- # FIXME: There is no need to shut down the ImageDiff server after every diff.
- self._process.stop()
-
diff_percent = 0
if output and output.startswith('diff'):
m = re.match('diff: (.+)% (passed|failed)', output)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
