Title: [159153] trunk/Source/_javascript_Core
Revision
159153
Author
[email protected]
Date
2013-11-12 15:09:39 -0800 (Tue, 12 Nov 2013)

Log Message

[sh4] Fix load32WithUnalignedHalfWords function in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=124233

Patch by Julien Brianceau <[email protected]> on 2013-11-12
Reviewed by Michael Saboff.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords): Do not claim scratch register too early.
Test already covered by fast/regex/pcre-test-1.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (159152 => 159153)


--- trunk/Source/_javascript_Core/ChangeLog	2013-11-12 23:04:46 UTC (rev 159152)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-11-12 23:09:39 UTC (rev 159153)
@@ -1,3 +1,14 @@
+2013-11-12  Julien Brianceau  <[email protected]>
+
+        [sh4] Fix load32WithUnalignedHalfWords function in baseline JIT.
+        https://bugs.webkit.org/show_bug.cgi?id=124233
+
+        Reviewed by Michael Saboff.
+
+        * assembler/MacroAssemblerSH4.h:
+        (JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords): Do not claim scratch register too early.
+        Test already covered by fast/regex/pcre-test-1.
+
 2013-11-12  Filip Pizlo  <[email protected]>
 
         Liveness analysis should take less memory in CodeBlock when it is unused

Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h (159152 => 159153)


--- trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h	2013-11-12 23:04:46 UTC (rev 159152)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h	2013-11-12 23:09:39 UTC (rev 159153)
@@ -1314,15 +1314,15 @@
     void load32WithUnalignedHalfWords(BaseIndex address, RegisterID dest)
     {
         RegisterID scr = claimScratch();
-        RegisterID scr1 = claimScratch();
         Jump m_jump;
         JumpList end;
 
+        loadEffectiveAddress(address, scr);
+
+        RegisterID scr1 = claimScratch();
         if (dest != SH4Registers::r0)
             move(SH4Registers::r0, scr1);
 
-        loadEffectiveAddress(address, scr);
-
         m_assembler.ensureSpace(m_assembler.maxInstructionSize + 58, sizeof(uint32_t));
         move(scr, SH4Registers::r0);
         m_assembler.testlImm8r(0x3, SH4Registers::r0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to