Diff
Modified: trunk/Source/WebCore/ChangeLog (159187 => 159188)
--- trunk/Source/WebCore/ChangeLog 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/ChangeLog 2013-11-13 11:59:18 UTC (rev 159188)
@@ -1,3 +1,44 @@
+2013-11-13 Tibor Meszaros <[email protected]>
+
+ Cleanup the build from unused parameters in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=124199.
+
+ Reviewed by Csaba Osztrogonác.
+
+ * css/CSSCursorImageValue.cpp:
+ (WebCore::CSSCursorImageValue::cachedOrPendingImage):
+ * dom/Document.cpp:
+ (WebCore::Document::scriptedAnimationControllerSetThrottled):
+ * fileapi/ThreadableBlobRegistry.cpp:
+ (WebCore::ThreadableBlobRegistry::registerBlobURL):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::shouldProhibitLinks):
+ * html/parser/XSSAuditor.cpp:
+ (WebCore::isSemicolonSeparatedAttribute):
+ * inspector/InspectorConsoleInstrumentation.h:
+ (WebCore::InspectorInstrumentation::addMessageToConsole):
+ * loader/DocumentThreadableLoader.cpp:
+ (WebCore::DocumentThreadableLoader::didReceiveData):
+ (WebCore::DocumentThreadableLoader::didFail):
+ (WebCore::DocumentThreadableLoader::preflightFailure):
+ * loader/cache/CachedImage.cpp:
+ (WebCore::CachedImage::imageSizeForRenderer):
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::animate):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::animate):
+ * platform/graphics/WidthIterator.cpp:
+ (WebCore::applyFontTransforms):
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::setIsInWindow):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::changeRequiresLayout):
+ (WebCore::RenderStyle::changeRequiresLayerRepaint):
+ (WebCore::RenderStyle::changeRequiresRecompositeLayer):
+ * testing/Internals.cpp:
+ (WebCore::Internals::setHeaderHeight):
+ (WebCore::Internals::setCaptionsStyleSheetOverride):
+
2013-11-13 Andreas Kling <[email protected]>
Refalize CSSCursorImageValue.
Modified: trunk/Source/WebCore/css/CSSCursorImageValue.cpp (159187 => 159188)
--- trunk/Source/WebCore/css/CSSCursorImageValue.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/css/CSSCursorImageValue.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -174,6 +174,8 @@
// Need to delegate completely so that changes in device scale factor can be handled appropriately.
if (m_imageValue.get().isImageSetValue())
return toCSSImageSetValue(m_imageValue.get()).cachedOrPendingImageSet(document);
+#else
+ UNUSED_PARAM(document);
#endif
if (!m_image)
Modified: trunk/Source/WebCore/dom/Document.cpp (159187 => 159188)
--- trunk/Source/WebCore/dom/Document.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/dom/Document.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -4870,6 +4870,8 @@
#if ENABLE(REQUEST_ANIMATION_FRAME)
if (m_scriptedAnimationController)
m_scriptedAnimationController->setThrottled(isThrottled);
+#else
+ UNUSED_PARAM(isThrottled);
#endif
}
Modified: trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.cpp (159187 => 159188)
--- trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/fileapi/ThreadableBlobRegistry.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -136,7 +136,7 @@
#else
-void ThreadableBlobRegistry::registerBlobURL(const URL&, std::unique_ptr<BlobData> blobData)
+void ThreadableBlobRegistry::registerBlobURL(const URL&, std::unique_ptr<BlobData>)
{
}
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (159187 => 159188)
--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -604,6 +604,7 @@
#if ENABLE(SVG)
return isInSVGImage(element);
#else
+ UNUSED_PARAM(element);
return false;
#endif
}
Modified: trunk/Source/WebCore/html/parser/XSSAuditor.cpp (159187 => 159188)
--- trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -186,6 +186,7 @@
#if ENABLE(SVG)
return threadSafeMatch(attribute.name, SVGNames::valuesAttr);
#else
+ UNUSED_PARAM(attribute);
return false;
#endif
}
Modified: trunk/Source/WebCore/inspector/InspectorConsoleInstrumentation.h (159187 => 159188)
--- trunk/Source/WebCore/inspector/InspectorConsoleInstrumentation.h 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/inspector/InspectorConsoleInstrumentation.h 2013-11-13 11:59:18 UTC (rev 159188)
@@ -87,6 +87,7 @@
UNUSED_PARAM(lineNumber);
UNUSED_PARAM(state);
UNUSED_PARAM(requestIdentifier);
+ UNUSED_PARAM(columnNumber);
#endif
}
Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp (159187 => 159188)
--- trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -293,6 +293,8 @@
if (m_actualRequest) {
#if ENABLE(INSPECTOR)
InspectorInstrumentation::didReceiveData(m_document->frame(), identifier, 0, 0, dataLength);
+#else
+ UNUSED_PARAM(identifier);
#endif
return;
}
@@ -329,6 +331,8 @@
#if ENABLE(INSPECTOR)
if (m_actualRequest)
InspectorInstrumentation::didFailLoading(m_document->frame(), m_document->frame()->loader().documentLoader(), identifier, error);
+#else
+ UNUSED_PARAM(identifier);
#endif
m_client->didFail(error);
@@ -353,6 +357,8 @@
#if ENABLE(INSPECTOR)
if (m_actualRequest)
InspectorInstrumentation::didFailLoading(m_document->frame(), m_document->frame()->loader().documentLoader(), identifier, error);
+#else
+ UNUSED_PARAM(identifier);
#endif
m_actualRequest = nullptr; // Prevent didFinishLoading() from bypassing access check.
m_client->didFailAccessControlCheck(error);
Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (159187 => 159188)
--- trunk/Source/WebCore/loader/cache/CachedImage.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -274,6 +274,8 @@
else if (m_image->isSVGImage() && sizeType == UsedSize) {
imageSize = m_svgImageCache->imageSizeForRenderer(renderer);
}
+#else
+ UNUSED_PARAM(sizeType);
#endif
if (multiplier == 1.0f)
Modified: trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp (159187 => 159188)
--- trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -77,10 +77,10 @@
if (!animatedStyle)
animatedStyle = RenderStyle::clone(targetStyle);
+#if USE(ACCELERATED_COMPOSITING)
bool needsAnim = CSSPropertyAnimation::blendProperties(this, m_animatingProperty, animatedStyle.get(), m_fromStyle.get(), m_toStyle.get(), progress(1, 0, 0));
// FIXME: we also need to detect cases where we have to software animate for other reasons,
// such as a child using inheriting the transform. https://bugs.webkit.org/show_bug.cgi?id=23902
-#if USE(ACCELERATED_COMPOSITING)
if (!needsAnim)
// If we are running an accelerated animation, set a flag in the style which causes the style
// to compare as different to any other style. This ensures that changes to the property
Modified: trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp (159187 => 159188)
--- trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -183,8 +183,8 @@
double progress = 0.0;
fetchIntervalEndpointsForProperty(*it, fromStyle, toStyle, progress);
+#if USE(ACCELERATED_COMPOSITING)
bool needsAnim = CSSPropertyAnimation::blendProperties(this, *it, animatedStyle.get(), fromStyle, toStyle, progress);
-#if USE(ACCELERATED_COMPOSITING)
if (!needsAnim)
// If we are running an accelerated animation, set a flag in the style
// to indicate it. This can be used to make sure we get an updated
Modified: trunk/Source/WebCore/platform/graphics/WidthIterator.cpp (159187 => 159188)
--- trunk/Source/WebCore/platform/graphics/WidthIterator.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/platform/graphics/WidthIterator.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -120,7 +120,9 @@
if (!ltr)
glyphBuffer->reverse(lastGlyphCount, glyphBufferSize - lastGlyphCount);
-#if ENABLE(SVG_FONTS)
+#if !ENABLE(SVG_FONTS)
+ UNUSED_PARAM(iterator);
+#else
// We need to handle transforms on SVG fonts internally, since they are rendered internally.
if (fontData->isSVGFont()) {
ASSERT(iterator.run().renderingContext());
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (159187 => 159188)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -1116,6 +1116,8 @@
#if USE(ACCELERATED_COMPOSITING)
if (m_compositor)
m_compositor->setIsInWindow(isInWindow);
+#else
+ UNUSED_PARAM(isInWindow);
#endif
}
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (159187 => 159188)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -466,6 +466,7 @@
changedContextSensitiveProperties |= ContextSensitivePropertyTransform;
// Don't return; keep looking for another change
#else
+ UNUSED_PARAM(changedContextSensitiveProperties);
return true;
#endif
}
@@ -703,6 +704,7 @@
changedContextSensitiveProperties |= ContextSensitivePropertyOpacity;
// Don't return; keep looking for another change.
#else
+ UNUSED_PARAM(changedContextSensitiveProperties);
return true;
#endif
}
@@ -787,6 +789,8 @@
|| rareNonInheritedData->m_perspectiveOriginY != other->rareNonInheritedData->m_perspectiveOriginY)
return true;
}
+#else
+ UNUSED_PARAM(other);
#endif
return false;
}
Modified: trunk/Source/WebCore/testing/Internals.cpp (159187 => 159188)
--- trunk/Source/WebCore/testing/Internals.cpp 2013-11-13 11:51:23 UTC (rev 159187)
+++ trunk/Source/WebCore/testing/Internals.cpp 2013-11-13 11:59:18 UTC (rev 159188)
@@ -1769,6 +1769,8 @@
#if USE(ACCELERATED_COMPOSITING)
FrameView* frameView = document->view();
frameView->setHeaderHeight(height);
+#else
+ UNUSED_PARAM(height);
#endif
}
@@ -2073,6 +2075,8 @@
#if ENABLE(VIDEO_TRACK) && !PLATFORM(WIN)
document->page()->group().captionPreferences()->setCaptionsStyleSheetOverride(override);
+#else
+ UNUSED_PARAM(override);
#endif
}
