Diff
Modified: trunk/Source/WebKit2/ChangeLog (159198 => 159199)
--- trunk/Source/WebKit2/ChangeLog 2013-11-13 16:23:14 UTC (rev 159198)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-13 17:01:27 UTC (rev 159199)
@@ -1,3 +1,16 @@
+2013-11-13 Anders Carlsson <[email protected]>
+
+ Add WKDeprecatedFunctions.cpp and move WKArrayIsMutable there
+ https://bugs.webkit.org/show_bug.cgi?id=124284
+
+ Reviewed by Andreas Kling.
+
+ * Shared/API/c/WKDeprecatedFunctions.cpp: Copied from Source/WebKit2/Shared/API/c/WKMutableArray.h.
+ (WKArrayIsMutable):
+ * Shared/API/c/WKMutableArray.cpp:
+ * Shared/API/c/WKMutableArray.h:
+ * WebKit2.xcodeproj/project.pbxproj:
+
2013-11-12 Anders Carlsson <[email protected]>
API::Object::Type should be a strongly typed enum
Copied: trunk/Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp (from rev 159198, trunk/Source/WebKit2/Shared/API/c/WKMutableArray.h) (0 => 159199)
--- trunk/Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp (rev 0)
+++ trunk/Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp 2013-11-13 17:01:27 UTC (rev 159199)
@@ -0,0 +1,37 @@
+/*
+ * Copyright (C) 2013 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#include "WKArray.h"
+
+// Deprecated functions that should be removed from the framework once nobody uses them.
+
+WK_EXPORT bool WKArrayIsMutable(WKArrayRef array);
+
+bool WKArrayIsMutable(WKArrayRef array)
+{
+ return false;
+}
Modified: trunk/Source/WebKit2/Shared/API/c/WKMutableArray.cpp (159198 => 159199)
--- trunk/Source/WebKit2/Shared/API/c/WKMutableArray.cpp 2013-11-13 16:23:14 UTC (rev 159198)
+++ trunk/Source/WebKit2/Shared/API/c/WKMutableArray.cpp 2013-11-13 17:01:27 UTC (rev 159199)
@@ -36,12 +36,6 @@
return const_cast<WKMutableArrayRef>(toAPI(ImmutableArray::create().leakRef()));
}
-bool WKArrayIsMutable(WKArrayRef arrayRef)
-{
- // FIXME: This function should be removed.
- return false;
-}
-
void WKArrayAppendItem(WKMutableArrayRef arrayRef, WKTypeRef itemRef)
{
toImpl(arrayRef)->elements().append(toImpl(itemRef));
Modified: trunk/Source/WebKit2/Shared/API/c/WKMutableArray.h (159198 => 159199)
--- trunk/Source/WebKit2/Shared/API/c/WKMutableArray.h 2013-11-13 16:23:14 UTC (rev 159198)
+++ trunk/Source/WebKit2/Shared/API/c/WKMutableArray.h 2013-11-13 17:01:27 UTC (rev 159199)
@@ -38,8 +38,6 @@
WK_EXPORT WKMutableArrayRef WKMutableArrayCreate();
-WK_EXPORT bool WKArrayIsMutable(WKArrayRef array);
-
WK_EXPORT void WKArrayAppendItem(WKMutableArrayRef array, WKTypeRef item);
WK_EXPORT void WKArrayRemoveItemAtIndex(WKMutableArrayRef array, size_t index);
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (159198 => 159199)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2013-11-13 16:23:14 UTC (rev 159198)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2013-11-13 17:01:27 UTC (rev 159199)
@@ -285,6 +285,7 @@
1AF05D8714688348008B1E81 /* TiledCoreAnimationDrawingAreaProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AF05D8514688348008B1E81 /* TiledCoreAnimationDrawingAreaProxy.h */; };
1AF1AC6B1651759E00C17D7F /* RemoteLayerTreeTransaction.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AF1AC691651759E00C17D7F /* RemoteLayerTreeTransaction.mm */; };
1AF1AC6C1651759E00C17D7F /* RemoteLayerTreeTransaction.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AF1AC6A1651759E00C17D7F /* RemoteLayerTreeTransaction.h */; };
+ 1AFF49001833DE78009AB15A /* WKDeprecatedFunctions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AFF48FE1833DE78009AB15A /* WKDeprecatedFunctions.cpp */; };
1C8E25A81270E3BB00BC7BD0 /* WebInspectorFrontendClient.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C8E256B1270DE3800BC7BD0 /* WebInspectorFrontendClient.cpp */; };
1C8E25A91270E3BC00BC7BD0 /* WebInspectorFrontendClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C8E256A1270DE3800BC7BD0 /* WebInspectorFrontendClient.h */; };
1C8E28201275D15400BC7BD0 /* WebInspector.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C8E281E1275D15400BC7BD0 /* WebInspector.h */; };
@@ -1771,6 +1772,7 @@
1AF05D8514688348008B1E81 /* TiledCoreAnimationDrawingAreaProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TiledCoreAnimationDrawingAreaProxy.h; sourceTree = "<group>"; };
1AF1AC691651759E00C17D7F /* RemoteLayerTreeTransaction.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = RemoteLayerTreeTransaction.mm; sourceTree = "<group>"; };
1AF1AC6A1651759E00C17D7F /* RemoteLayerTreeTransaction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RemoteLayerTreeTransaction.h; sourceTree = "<group>"; };
+ 1AFF48FE1833DE78009AB15A /* WKDeprecatedFunctions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WKDeprecatedFunctions.cpp; sourceTree = "<group>"; };
1BB417C912C00CCA002BE67B /* TextCheckerCompletion.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TextCheckerCompletion.cpp; sourceTree = "<group>"; };
1C77C1951288A872006A742F /* WebInspectorProxy.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = WebInspectorProxy.messages.in; sourceTree = "<group>"; };
1C8E256A1270DE3800BC7BD0 /* WebInspectorFrontendClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebInspectorFrontendClient.h; sourceTree = "<group>"; };
@@ -5169,6 +5171,7 @@
BC4075DB124FF0270068F20A /* WKData.cpp */,
BC4075DC124FF0270068F20A /* WKData.h */,
377EAD4417E2C51A002D193D /* WKDeclarationSpecifiers.h */,
+ 1AFF48FE1833DE78009AB15A /* WKDeprecatedFunctions.cpp */,
BC4075DD124FF0270068F20A /* WKDictionary.cpp */,
BC4075DE124FF0270068F20A /* WKDictionary.h */,
BC4075DF124FF0270068F20A /* WKError.cpp */,
@@ -7012,6 +7015,7 @@
1A44B95B16B73F9F00B7BBD8 /* StorageManager.cpp in Sources */,
1AB31A9616BC688100F6DBC9 /* StorageManagerMessageReceiver.cpp in Sources */,
1A44B95716B737AA00B7BBD8 /* StorageNamespaceImpl.cpp in Sources */,
+ 1AFF49001833DE78009AB15A /* WKDeprecatedFunctions.cpp in Sources */,
517DD5BE180DA7D30081660B /* DatabaseProcessProxy.cpp in Sources */,
296BD85E15019BC30071F424 /* StringUtilities.mm in Sources */,
1ZZ417EF12C00D87002BE67B /* TextCheckerCompletion.cpp in Sources */,