Title: [159211] trunk
- Revision
- 159211
- Author
- [email protected]
- Date
- 2013-11-13 11:19:44 -0800 (Wed, 13 Nov 2013)
Log Message
crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html is failing on Maverics release bot
https://bugs.webkit.org/show_bug.cgi?id=124280
Reviewed by Anders Carlsson.
Source/WebCore:
* crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::buildAlgorithmDescription):
Don't be a muppet, initialize your variables.
LayoutTests:
* TestExpectations: Unskip.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (159210 => 159211)
--- trunk/LayoutTests/ChangeLog 2013-11-13 19:12:37 UTC (rev 159210)
+++ trunk/LayoutTests/ChangeLog 2013-11-13 19:19:44 UTC (rev 159211)
@@ -1,3 +1,12 @@
+2013-11-13 Alexey Proskuryakov <[email protected]>
+
+ crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html is failing on Maverics release bot
+ https://bugs.webkit.org/show_bug.cgi?id=124280
+
+ Reviewed by Anders Carlsson.
+
+ * TestExpectations: Unskip.
+
2013-11-12 Jer Noble <[email protected]>
Add support for HTMLMediaElement.fastSeek()
Modified: trunk/LayoutTests/TestExpectations (159210 => 159211)
--- trunk/LayoutTests/TestExpectations 2013-11-13 19:12:37 UTC (rev 159210)
+++ trunk/LayoutTests/TestExpectations 2013-11-13 19:19:44 UTC (rev 159211)
@@ -69,5 +69,3 @@
# The spec is not clear if the MediaStream ended event should be fired if stop is called on each MediaStream's track
# Skipping it for now, then put it again when the spec decides it
fast/mediastream/MediaStream-onended.html [ Skip ]
-
-webkit.org/b/124280 crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (159210 => 159211)
--- trunk/Source/WebCore/ChangeLog 2013-11-13 19:12:37 UTC (rev 159210)
+++ trunk/Source/WebCore/ChangeLog 2013-11-13 19:19:44 UTC (rev 159211)
@@ -1,3 +1,13 @@
+2013-11-13 Alexey Proskuryakov <[email protected]>
+
+ crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html is failing on Maverics release bot
+ https://bugs.webkit.org/show_bug.cgi?id=124280
+
+ Reviewed by Anders Carlsson.
+
+ * crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::buildAlgorithmDescription):
+ Don't be a muppet, initialize your variables.
+
2013-11-12 Jer Noble <[email protected]>
Add support for HTMLMediaElement.fastSeek()
Modified: trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp (159210 => 159211)
--- trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2013-11-13 19:12:37 UTC (rev 159210)
+++ trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2013-11-13 19:19:44 UTC (rev 159211)
@@ -112,12 +112,15 @@
bool platformKeyIsPublic = CCRSAGetKeyType(m_platformKey) == ccRSAKeyPublic;
CCRSACryptorRef publicKey = platformKeyIsPublic ? m_platformKey : CCRSACryptorGetPublicKeyFromPrivateKey(m_platformKey);
- size_t modulusLength;
- size_t exponentLength;
+ uint8_t modulus[16384];
+ size_t modulusLength = sizeof(modulus);
uint8_t publicExponent[16384];
- size_t dummy;
- uint8_t buf[16384];
- CCCryptorStatus status = CCRSAGetKeyComponents(publicKey, buf, &modulusLength, publicExponent, &exponentLength, buf, &dummy, buf, &dummy);
+ size_t exponentLength = sizeof(16384);
+ uint8_t p[16384];
+ size_t pLength = sizeof(p);
+ uint8_t q[16384];
+ size_t qLength = sizeof(q);
+ CCCryptorStatus status = CCRSAGetKeyComponents(publicKey, modulus, &modulusLength, publicExponent, &exponentLength, p, &pLength, q, &qLength);
if (!platformKeyIsPublic) {
// CCRSACryptorGetPublicKeyFromPrivateKey has "Get" in the name, but its result needs to be released (see <rdar://problem/15449697>).
CCRSACryptorRelease(publicKey);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
