Title: [159428] trunk/Source/_javascript_Core
Revision
159428
Author
[email protected]
Date
2013-11-18 10:19:23 -0800 (Mon, 18 Nov 2013)

Log Message

ARM64 CRASH: Improper offset in getHostCallReturnValue() to access callerFrame in CallFrame
https://bugs.webkit.org/show_bug.cgi?id=124481

Reviewed by Mark Lam.

Fixed the offset to access CallerFrame in the ARM64 version of getHostCallReturnValue() to be 0
to correspond with the change in CallFrame layout done in r158315.

* jit/JITOperations.cpp:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (159427 => 159428)


--- trunk/Source/_javascript_Core/ChangeLog	2013-11-18 17:56:27 UTC (rev 159427)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-11-18 18:19:23 UTC (rev 159428)
@@ -1,5 +1,17 @@
 2013-11-18  Michael Saboff  <[email protected]>
 
+        ARM64 CRASH: Improper offset in getHostCallReturnValue() to access callerFrame in CallFrame
+        https://bugs.webkit.org/show_bug.cgi?id=124481
+
+        Reviewed by Mark Lam.
+
+        Fixed the offset to access CallerFrame in the ARM64 version of getHostCallReturnValue() to be 0
+        to correspond with the change in CallFrame layout done in r158315.
+
+        * jit/JITOperations.cpp:
+
+2013-11-18  Michael Saboff  <[email protected]>
+
         Crash in virtualForThunkGenerator generated code on ARM64
         https://bugs.webkit.org/show_bug.cgi?id=124447
 

Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (159427 => 159428)


--- trunk/Source/_javascript_Core/jit/JITOperations.cpp	2013-11-18 17:56:27 UTC (rev 159427)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp	2013-11-18 18:19:23 UTC (rev 159428)
@@ -1766,7 +1766,7 @@
 ".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"
 HIDE_SYMBOL(getHostCallReturnValue) "\n"
 SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
-    "ldur x25, [x25, #-32]" "\n"
+    "ldur x25, [x25, #0]" "\n"
      "mov x0, x25" "\n"
      "b " LOCAL_REFERENCE(getHostCallReturnValueWithExecState) "\n"
 );
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to