Title: [159441] trunk/Source/WebKit2
- Revision
- 159441
- Author
- [email protected]
- Date
- 2013-11-18 11:44:31 -0800 (Mon, 18 Nov 2013)
Log Message
[ASAN] WebKit2: Remove calls to dead DownloadAuthenticationClient code
https://bugs.webkit.org/show_bug.cgi?id=124367
Reviewed by Alexey Proskuryakov.
* Shared/Downloads/DownloadAuthenticationClient.cpp:
(WebKit::DownloadAuthenticationClient::receivedCredential):
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Remove calls to nowhere:
WebKit::Download::cancelAuthenticationChallenge(WebCore::AuthenticationChallenge const&)
WebKit::Download::continueWithoutCredential(WebCore::AuthenticationChallenge const&)
WebKit::Download::useCredential(WebCore::AuthenticationChallenge const&, WebCore::Credential const&)
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (159440 => 159441)
--- trunk/Source/WebKit2/ChangeLog 2013-11-18 19:34:21 UTC (rev 159440)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-18 19:44:31 UTC (rev 159441)
@@ -1,3 +1,19 @@
+2013-11-14 David Farler <[email protected]>
+
+ [ASAN] WebKit2: Remove calls to dead DownloadAuthenticationClient code
+ https://bugs.webkit.org/show_bug.cgi?id=124367
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Shared/Downloads/DownloadAuthenticationClient.cpp:
+ (WebKit::DownloadAuthenticationClient::receivedCredential):
+ (WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
+ (WebKit::DownloadAuthenticationClient::receivedCancellation):
+ Remove calls to nowhere:
+ WebKit::Download::cancelAuthenticationChallenge(WebCore::AuthenticationChallenge const&)
+ WebKit::Download::continueWithoutCredential(WebCore::AuthenticationChallenge const&)
+ WebKit::Download::useCredential(WebCore::AuthenticationChallenge const&, WebCore::Credential const&)
+
2013-11-18 Anders Carlsson <[email protected]>
Use a strong enum for frame load states
Modified: trunk/Source/WebKit2/Shared/Downloads/DownloadAuthenticationClient.cpp (159440 => 159441)
--- trunk/Source/WebKit2/Shared/Downloads/DownloadAuthenticationClient.cpp 2013-11-18 19:34:21 UTC (rev 159440)
+++ trunk/Source/WebKit2/Shared/Downloads/DownloadAuthenticationClient.cpp 2013-11-18 19:44:31 UTC (rev 159441)
@@ -40,23 +40,17 @@
void DownloadAuthenticationClient::receivedCredential(const AuthenticationChallenge& challenge, const Credential& credential)
{
- if (!m_download)
- return;
- m_download->useCredential(challenge, credential);
+ // FIXME (119667): This can probably be just removed.
}
void DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential(const AuthenticationChallenge& challenge)
{
- if (!m_download)
- return;
- m_download->continueWithoutCredential(challenge);
+ // FIXME (119667): This can probably be just removed.
}
void DownloadAuthenticationClient::receivedCancellation(const AuthenticationChallenge& challenge)
{
- if (!m_download)
- return;
- m_download->cancelAuthenticationChallenge(challenge);
+ // FIXME (119667): This can probably be just removed.
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
