Title: [159454] trunk/Source/WebCore
Revision
159454
Author
commit-qu...@webkit.org
Date
2013-11-18 13:49:03 -0800 (Mon, 18 Nov 2013)

Log Message

[GStreamer] Crash when using media source
https://bugs.webkit.org/show_bug.cgi?id=124525

Patch by Brendan Long <b.l...@cablelabs.com> on 2013-11-18
Reviewed by Philippe Normand.

No new tests because this is already covered by tests in media/media-source (which aren't enabled because the feature isn't done).

* platform/graphics/gstreamer/MediaSourceGStreamer.cpp:
(WebCore::MediaSourceGStreamer::MediaSourceGStreamer): Add missing adoptRef()

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (159453 => 159454)


--- trunk/Source/WebCore/ChangeLog	2013-11-18 21:48:18 UTC (rev 159453)
+++ trunk/Source/WebCore/ChangeLog	2013-11-18 21:49:03 UTC (rev 159454)
@@ -1,3 +1,15 @@
+2013-11-18  Brendan Long  <b.l...@cablelabs.com>
+
+        [GStreamer] Crash when using media source
+        https://bugs.webkit.org/show_bug.cgi?id=124525
+
+        Reviewed by Philippe Normand.
+
+        No new tests because this is already covered by tests in media/media-source (which aren't enabled because the feature isn't done).
+
+        * platform/graphics/gstreamer/MediaSourceGStreamer.cpp:
+        (WebCore::MediaSourceGStreamer::MediaSourceGStreamer): Add missing adoptRef()
+
 2013-11-18  Brady Eidson  <beid...@apple.com>
 
         Remove unneeded BackingStore-related #include from IDBFactoryBackendInterface

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaSourceGStreamer.cpp (159453 => 159454)


--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaSourceGStreamer.cpp	2013-11-18 21:48:18 UTC (rev 159453)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaSourceGStreamer.cpp	2013-11-18 21:49:03 UTC (rev 159454)
@@ -46,7 +46,7 @@
 }
 
 MediaSourceGStreamer::MediaSourceGStreamer(WebKitMediaSrc* src)
-    : m_client(new MediaSourceClientGstreamer(src))
+    : m_client(adoptRef(new MediaSourceClientGstreamer(src)))
     , m_duration(0.0)
     , m_readyState(MediaPlayer::HaveNothing)
 {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to