Title: [159469] trunk/Source/_javascript_Core
Revision
159469
Author
[email protected]
Date
2013-11-18 16:35:15 -0800 (Mon, 18 Nov 2013)

Log Message

ARM64 CRASH: Debug builds crash in emitPointerValidation()
https://bugs.webkit.org/show_bug.cgi?id=124545

Reviewed by Filip Pizlo.

Changed emitPointerValidation() to use pushToSave() and popToRestore() as
all macro assemblers have an implementation of these functions.

* jit/ThunkGenerators.cpp:
(JSC::emitPointerValidation):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (159468 => 159469)


--- trunk/Source/_javascript_Core/ChangeLog	2013-11-19 00:32:44 UTC (rev 159468)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-11-19 00:35:15 UTC (rev 159469)
@@ -1,5 +1,18 @@
 2013-11-18  Michael Saboff  <[email protected]>
 
+        ARM64 CRASH: Debug builds crash in emitPointerValidation()
+        https://bugs.webkit.org/show_bug.cgi?id=124545
+
+        Reviewed by Filip Pizlo.
+
+        Changed emitPointerValidation() to use pushToSave() and popToRestore() as
+        all macro assemblers have an implementation of these functions.
+
+        * jit/ThunkGenerators.cpp:
+        (JSC::emitPointerValidation):
+
+2013-11-18  Michael Saboff  <[email protected]>
+
         ARM64: Update getHostCallReturnValue() to use architected frame pointer register
         https://bugs.webkit.org/show_bug.cgi?id=124520
 

Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (159468 => 159469)


--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp	2013-11-19 00:32:44 UTC (rev 159468)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp	2013-11-19 00:35:15 UTC (rev 159469)
@@ -47,9 +47,9 @@
     CCallHelpers::Jump isNonZero = jit.branchTestPtr(CCallHelpers::NonZero, pointerGPR);
     jit.breakpoint();
     isNonZero.link(&jit);
-    jit.push(pointerGPR);
+    jit.pushToSave(pointerGPR);
     jit.load8(pointerGPR, pointerGPR);
-    jit.pop(pointerGPR);
+    jit.popToRestore(pointerGPR);
 #else
     UNUSED_PARAM(jit);
     UNUSED_PARAM(pointerGPR);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to