Title: [159484] trunk/Tools
- Revision
- 159484
- Author
- [email protected]
- Date
- 2013-11-18 22:47:53 -0800 (Mon, 18 Nov 2013)
Log Message
build.webkit.org/dashboard builder headers should link to the builder page
https://bugs.webkit.org/show_bug.cgi?id=124553
Reviewed by Timothy Hatcher.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.get overviewURL):
Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
(BuildbotBuilderQueueView.prototype.update):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype.update.appendBuild):
(BuildbotTesterQueueView.prototype.update):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
(.queue-view .queueLabel):
(.queue-view .queueLabel:not(:first-child)):
Make the header a link instead of a label, and wire it up to overviewURL.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js (159483 => 159484)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2013-11-19 06:30:56 UTC (rev 159483)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js 2013-11-19 06:47:53 UTC (rev 159484)
@@ -96,14 +96,16 @@
function appendBuildArchitecture(queues, label)
{
- if (!queues.length)
- return;
+ queues.forEach(function(queue) {
+ var releaseLabel = document.createElement("a");
+ releaseLabel.classList.add("queueLabel");
+ releaseLabel.textContent = label;
+ releaseLabel.href = ""
+ releaseLabel.target = "_blank";
+ this.element.appendChild(releaseLabel);
- var releaseLabel = document.createElement("label");
- releaseLabel.textContent = label;
- this.element.appendChild(releaseLabel);
-
- queues.forEach(appendBuilderQueueStatus.bind(this));
+ appendBuilderQueueStatus.call(this, queue);
+ }.bind(this));
}
appendBuildArchitecture.call(this, this.universalReleaseQueues, this.hasMultipleReleaseBuilds ? "Release (Universal)" : "Release");
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (159483 => 159484)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2013-11-19 06:30:56 UTC (rev 159483)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2013-11-19 06:47:53 UTC (rev 159484)
@@ -63,6 +63,11 @@
return this.buildbot.baseURL + "json/builders/" + encodeURIComponent(this.id);
},
+ get overviewURL()
+ {
+ return this.buildbot.baseURL + "builders/" + encodeURIComponent(this.id) + "?numbuilds=50";
+ },
+
get pendingIterationsCount()
{
var firstFinishedIteration = this.mostRecentFinishedIteration;
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (159483 => 159484)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2013-11-19 06:30:56 UTC (rev 159483)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2013-11-19 06:47:53 UTC (rev 159484)
@@ -106,21 +106,23 @@
}
if (!appendedStatus) {
- var status = new StatusLineView("unknown", StatusLineView.Status.Neutral, "last passing build");
+ var status = new StatusLineView("unknown", StatusLineView.Status.Neutral, "last passing build");
this.element.appendChild(status.element);
}
}
function appendBuild(queues, label)
{
- if (!queues.length)
- return;
+ queues.forEach(function(queue) {
+ var releaseLabel = document.createElement("a");
+ releaseLabel.classList.add("queueLabel");
+ releaseLabel.textContent = label;
+ releaseLabel.href = ""
+ releaseLabel.target = "_blank";
+ this.element.appendChild(releaseLabel);
- var releaseLabel = document.createElement("label");
- releaseLabel.textContent = label;
- this.element.appendChild(releaseLabel);
-
- queues.forEach(appendBuilderQueueStatus.bind(this));
+ appendBuilderQueueStatus.call(this, queue);
+ }.bind(this));
}
appendBuild.call(this, this.releaseQueues, "Release");
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css (159483 => 159484)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css 2013-11-19 06:30:56 UTC (rev 159483)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css 2013-11-19 06:47:53 UTC (rev 159484)
@@ -29,13 +29,14 @@
padding: 10px 20px;
}
-.queue-view label {
+.queue-view .queueLabel {
display: block;
font-family: "HelveticaNeue-Light", "Helvetica Neue", sans-serif;
color: rgb(145, 135, 95);
text-align: left;
+ text-decoration: none;
}
-.queue-view label:not(:first-child) {
+.queue-view .queueLabel:not(:first-child) {
margin-top: 10px;
}
Modified: trunk/Tools/ChangeLog (159483 => 159484)
--- trunk/Tools/ChangeLog 2013-11-19 06:30:56 UTC (rev 159483)
+++ trunk/Tools/ChangeLog 2013-11-19 06:47:53 UTC (rev 159484)
@@ -1,3 +1,26 @@
+2013-11-18 Tim Horton <[email protected]>
+
+ build.webkit.org/dashboard builder headers should link to the builder page
+ https://bugs.webkit.org/show_bug.cgi?id=124553
+
+ Reviewed by Timothy Hatcher.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ (BuildbotQueue.prototype.get overviewURL):
+ Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+ (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
+ (BuildbotBuilderQueueView.prototype.update):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
+ (BuildbotTesterQueueView.prototype.update.appendBuild):
+ (BuildbotTesterQueueView.prototype.update):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
+ (.queue-view .queueLabel):
+ (.queue-view .queueLabel:not(:first-child)):
+ Make the header a link instead of a label, and wire it up to overviewURL.
+
2013-11-18 Samuel White <[email protected]>
AX: Add ability to fetch only visible table rows.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
