Log Message
Allow settings to be shown/hidden on build.webkit.org/dashboard https://bugs.webkit.org/show_bug.cgi?id=124694
Reviewed by Tim Horton. In preparation for more options/buttons, allow the page to show or hide all the interactive things using a little gear icon in the top left corner. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: (Settings.prototype.toggleSettingsDisplay): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (div.cellButton.hide): (div.cellButton.unhide): (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): (.settings): (.settings:hover): (.settings-visible .settings):
Modified Paths
- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js
- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js
- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
- trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (159601 => 159602)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2013-11-21 01:59:45 UTC (rev 159601)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2013-11-21 02:00:10 UTC (rev 159602)
@@ -177,6 +177,11 @@
document.body.appendChild(table);
+ var settingsButton = document.createElement("div");
+ settingsButton.addEventListener("click", function () { settings.toggleSettingsDisplay(); });
+ settingsButton.classList.add("settings");
+ document.body.appendChild(settingsButton);
+
updateHiddenPlatforms();
settings.addSettingListener("hiddenPlatforms", updateHiddenPlatforms);
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js (159601 => 159602)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js 2013-11-21 01:59:45 UTC (rev 159601)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js 2013-11-21 02:00:10 UTC (rev 159602)
@@ -62,6 +62,11 @@
callbacks[i]();
},
+ toggleSettingsDisplay: function()
+ {
+ document.body.classList.toggle("settings-visible");
+ },
+
toggleHiddenPlatform: function(platform)
{
var hiddenPlatforms = this.getObject("hiddenPlatforms");
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (159601 => 159602)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-11-21 01:59:45 UTC (rev 159601)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-11-21 02:00:10 UTC (rev 159602)
@@ -46,15 +46,42 @@
}
div.cellButton.hide {
+ display: none;
position: absolute;
bottom: 2px;
right: 4px;
}
+div.cellButton.unhide {
+ display: none;
+}
+
+.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide {
+ display: block;
+}
+
.hidden {
display: none;
}
+.settings {
+ position: absolute;
+ top: 5px;
+ left: 5px;
+ width: 35px;
+ height: 35px;
+ background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 250 250"><path fill="rgb(166, 158, 130)" d="M213,144v-39h-21.055c-1.476-5-3.51-10.085-6.051-14.668l14.673-14.697l-27.578-27.589l-14.521,14.665 C153.885,60.17,149,58.13,144,56.654V36h-39v20.654c-5,1.476-10.186,3.51-14.769,6.051L75.484,48.033L47.869,75.609l14.652,14.723 C59.981,94.915,57.929,100,56.453,105H36v39h20.453c1.476,5,3.511,9.985,6.051,14.569l-14.672,14.646l27.577,27.565l14.822-14.679 c4.583,2.541,9.769,4.569,14.769,6.045V213h39v-20.854c5-1.476,9.885-3.51,14.468-6.051l14.597,14.672l27.541-27.576l-14.691-14.623 c2.54-4.583,4.556-9.568,6.031-14.568H213z M124.199,164.9c-22.367,0-40.5-18.133-40.5-40.5s18.133-40.5,40.5-40.5 s40.5,18.133,40.5,40.5S146.566,164.9,124.199,164.9z"/></svg>');
+ cursor: pointer;
+}
+
+.settings:hover {
+ background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 250 250"><path fill="rgb(185, 175, 125)" d="M213,144v-39h-21.055c-1.476-5-3.51-10.085-6.051-14.668l14.673-14.697l-27.578-27.589l-14.521,14.665 C153.885,60.17,149,58.13,144,56.654V36h-39v20.654c-5,1.476-10.186,3.51-14.769,6.051L75.484,48.033L47.869,75.609l14.652,14.723 C59.981,94.915,57.929,100,56.453,105H36v39h20.453c1.476,5,3.511,9.985,6.051,14.569l-14.672,14.646l27.577,27.565l14.822-14.679 c4.583,2.541,9.769,4.569,14.769,6.045V213h39v-20.854c5-1.476,9.885-3.51,14.468-6.051l14.597,14.672l27.541-27.576l-14.691-14.623 c2.54-4.583,4.556-9.568,6.031-14.568H213z M124.199,164.9c-22.367,0-40.5-18.133-40.5-40.5s18.133-40.5,40.5-40.5 s40.5,18.133,40.5,40.5S146.566,164.9,124.199,164.9z"/></svg>');
+}
+
+.settings-visible .settings {
+ background-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 250 250"><path fill="rgb(76, 151, 61)" d="M213,144v-39h-21.055c-1.476-5-3.51-10.085-6.051-14.668l14.673-14.697l-27.578-27.589l-14.521,14.665 C153.885,60.17,149,58.13,144,56.654V36h-39v20.654c-5,1.476-10.186,3.51-14.769,6.051L75.484,48.033L47.869,75.609l14.652,14.723 C59.981,94.915,57.929,100,56.453,105H36v39h20.453c1.476,5,3.511,9.985,6.051,14.569l-14.672,14.646l27.577,27.565l14.822-14.679 c4.583,2.541,9.769,4.569,14.769,6.045V213h39v-20.854c5-1.476,9.885-3.51,14.468-6.051l14.597,14.672l27.541-27.576l-14.691-14.623 c2.54-4.583,4.556-9.568,6.031-14.568H213z M124.199,164.9c-22.367,0-40.5-18.133-40.5-40.5s18.133-40.5,40.5-40.5 s40.5,18.133,40.5,40.5S146.566,164.9,124.199,164.9z"/></svg>');
+}
+
body {
background-color: rgb(233, 231, 223);
text-align: center;
Modified: trunk/Tools/ChangeLog (159601 => 159602)
--- trunk/Tools/ChangeLog 2013-11-21 01:59:45 UTC (rev 159601)
+++ trunk/Tools/ChangeLog 2013-11-21 02:00:10 UTC (rev 159602)
@@ -1,5 +1,27 @@
2013-11-20 Dean Jackson <[email protected]>
+ Allow settings to be shown/hidden on build.webkit.org/dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=124694
+
+ Reviewed by Tim Horton.
+
+ In preparation for more options/buttons, allow the page to
+ show or hide all the interactive things using a little gear icon
+ in the top left corner.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
+ (Settings.prototype.toggleSettingsDisplay):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ (div.cellButton.hide):
+ (div.cellButton.unhide):
+ (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
+ (.settings):
+ (.settings:hover):
+ (.settings-visible .settings):
+
+2013-11-20 Dean Jackson <[email protected]>
+
No need to base64 SVG on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124687
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
