Title: [159649] trunk/Source
- Revision
- 159649
- Author
- [email protected]
- Date
- 2013-11-21 15:20:38 -0800 (Thu, 21 Nov 2013)
Log Message
Remove unused functions from WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124739
Reviewed by Alexey Proskuryakov.
Source/WebCore:
* editing/markup.cpp: Remove unused functions isHTMLBlockElement and
ancestorToRetainStructureAndAppearanceWithNoRenderer.
* rendering/InlineElementBox.cpp: Append newline to the end of the file.
Source/WebKit2:
Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).
* UIProcess/API/mac/WKBrowsingContextController.mm:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (159648 => 159649)
--- trunk/Source/WebCore/ChangeLog 2013-11-21 23:19:25 UTC (rev 159648)
+++ trunk/Source/WebCore/ChangeLog 2013-11-21 23:20:38 UTC (rev 159649)
@@ -1,5 +1,16 @@
2013-11-21 Daniel Bates <[email protected]>
+ Remove unused functions from WebCore and WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=124739
+
+ Reviewed by Alexey Proskuryakov.
+
+ * editing/markup.cpp: Remove unused functions isHTMLBlockElement and
+ ancestorToRetainStructureAndAppearanceWithNoRenderer.
+ * rendering/InlineElementBox.cpp: Append newline to the end of the file.
+
+2013-11-21 Daniel Bates <[email protected]>
+
Only generate isObservable() when IDL specifies GenerateIsReachable
https://bugs.webkit.org/show_bug.cgi?id=124729
Modified: trunk/Source/WebCore/editing/markup.cpp (159648 => 159649)
--- trunk/Source/WebCore/editing/markup.cpp 2013-11-21 23:19:25 UTC (rev 159648)
+++ trunk/Source/WebCore/editing/markup.cpp 2013-11-21 23:20:38 UTC (rev 159649)
@@ -430,13 +430,6 @@
return lastClosed;
}
-static bool isHTMLBlockElement(const Node* node)
-{
- return node->hasTagName(tdTag)
- || node->hasTagName(thTag)
- || isNonTableCellHTMLBlockElement(node);
-}
-
static Node* ancestorToRetainStructureAndAppearanceForBlock(Node* commonAncestorBlock)
{
if (!commonAncestorBlock)
@@ -461,12 +454,6 @@
return ancestorToRetainStructureAndAppearanceForBlock(enclosingBlock(commonAncestor));
}
-static inline Node* ancestorToRetainStructureAndAppearanceWithNoRenderer(Node* commonAncestor)
-{
- Node* commonAncestorBlock = enclosingNodeOfType(firstPositionInOrBeforeNode(commonAncestor), isHTMLBlockElement);
- return ancestorToRetainStructureAndAppearanceForBlock(commonAncestorBlock);
-}
-
static bool propertyMissingOrEqualToNone(StylePropertySet* style, CSSPropertyID propertyID)
{
if (!style)
Modified: trunk/Source/WebCore/rendering/InlineElementBox.cpp (159648 => 159649)
--- trunk/Source/WebCore/rendering/InlineElementBox.cpp 2013-11-21 23:19:25 UTC (rev 159648)
+++ trunk/Source/WebCore/rendering/InlineElementBox.cpp 2013-11-21 23:20:38 UTC (rev 159649)
@@ -102,4 +102,4 @@
return renderer().hitTest(request, result, locationInContainer, childPoint);
}
-}
\ No newline at end of file
+}
Modified: trunk/Source/WebKit2/ChangeLog (159648 => 159649)
--- trunk/Source/WebKit2/ChangeLog 2013-11-21 23:19:25 UTC (rev 159648)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-21 23:20:38 UTC (rev 159649)
@@ -1,3 +1,14 @@
+2013-11-21 Daniel Bates <[email protected]>
+
+ Remove unused functions from WebCore and WebKit2
+ https://bugs.webkit.org/show_bug.cgi?id=124739
+
+ Reviewed by Alexey Proskuryakov.
+
+ Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).
+
+ * UIProcess/API/mac/WKBrowsingContextController.mm:
+
2013-11-21 Csaba Osztrogonác <[email protected]>
Rename PlatformCertificateInfo to CertificateInfo
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm (159648 => 159649)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm 2013-11-21 23:19:25 UTC (rev 159648)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm 2013-11-21 23:20:38 UTC (rev 159649)
@@ -64,16 +64,6 @@
return url ? CFBridgingRelease(WKURLCopyCFURL(kCFAllocatorDefault, adoptWK(url).get())) : nil;
}
-static inline NSURLRequest *autoreleased(WKURLRequestRef urlRequest)
-{
- return urlRequest ? CFBridgingRelease(WKURLRequestCopyNSURLRequest(adoptWK(urlRequest).get())) : nil;
-}
-
-static inline NSURLResponse *autoreleased(WKURLResponseRef urlResponse)
-{
- return urlResponse ? CFBridgingRelease(WKURLResponseCopyNSURLResponse(adoptWK(urlResponse).get())) : nil;
-}
-
NSString * const WKActionIsMainFrameKey = @"WKActionIsMainFrameKey";
NSString * const WKActionNavigationTypeKey = @"WKActionNavigationTypeKey";
NSString * const WKActionMouseButtonKey = @"WKActionMouseButtonKey";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
