Title: [159659] trunk/Tools
- Revision
- 159659
- Author
- [email protected]
- Date
- 2013-11-21 18:12:12 -0800 (Thu, 21 Nov 2013)
Log Message
Don't fetch hidden platforms on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124750
Reviewed by Tim Horton.
If a platform is hidden, don't fetch its data. If it
becomes unhidden, try to fetch immediately (unless
you've recently fetched).
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (159658 => 159659)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2013-11-22 01:29:28 UTC (rev 159658)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2013-11-22 02:12:12 UTC (rev 159659)
@@ -131,6 +131,10 @@
update: function(iterationsToLoad)
{
+ var hiddenPlatforms = settings.getObject("hiddenPlatforms");
+ if (hiddenPlatforms.contains(this.platform))
+ return;
+
JSON.load(this.baseURL, function(data) {
if (!(data.cachedBuilds instanceof Array))
return;
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (159658 => 159659)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2013-11-22 01:29:28 UTC (rev 159658)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2013-11-22 02:12:12 UTC (rev 159659)
@@ -42,7 +42,9 @@
queue.addEventListener(BuildbotQueue.Event.IterationsAdded, this._queueIterationsAdded, this);
}.bind(this));
- setInterval(this._updateQueues.bind(this), BuildbotQueueView.UpdateInterval);
+ this.lastUpdate = 0;
+ setTimeout(this._updateQueues.bind(this), BuildbotQueueView.UpdateInterval);
+ settings.addSettingListener("hiddenPlatforms", this._updateQueues.bind(this));
};
BaseObject.addConstructorFunctions(BuildbotQueueView);
@@ -105,8 +107,13 @@
_updateQueues: function()
{
+ var now = Date.now();
+ if (now - this.lastUpdate < BuildbotQueueView.UpdateInterval)
+ return;
this.releaseQueues.forEach(function(queue) { queue.update(); });
this.debugQueues.forEach(function(queue) { queue.update(); });
+ this.lastUpdate = now;
+ setTimeout(this._updateQueues.bind(this), BuildbotQueueView.UpdateInterval);
},
_queueIterationsAdded: function(event)
Modified: trunk/Tools/ChangeLog (159658 => 159659)
--- trunk/Tools/ChangeLog 2013-11-22 01:29:28 UTC (rev 159658)
+++ trunk/Tools/ChangeLog 2013-11-22 02:12:12 UTC (rev 159659)
@@ -1,3 +1,17 @@
+2013-11-21 Dean Jackson <[email protected]>
+
+ Don't fetch hidden platforms on build.webkit.org/dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=124750
+
+ Reviewed by Tim Horton.
+
+ If a platform is hidden, don't fetch its data. If it
+ becomes unhidden, try to fetch immediately (unless
+ you've recently fetched).
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+
2013-11-21 Commit Queue <[email protected]>
Unreviewed, rolling out r159633.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
