Title: [159793] trunk/Source/WebCore
Revision
159793
Author
akl...@apple.com
Date
2013-11-26 15:36:00 -0800 (Tue, 26 Nov 2013)

Log Message

RenderObject: Inline isBody() and isHR().
<https://webkit.org/b/124901>

Together these account for ~0.3% of samples on HTML5-8266.
Almost all of it is call overhead.

Reviewed by Anders Carlsson.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (159792 => 159793)


--- trunk/Source/WebCore/ChangeLog	2013-11-26 23:05:28 UTC (rev 159792)
+++ trunk/Source/WebCore/ChangeLog	2013-11-26 23:36:00 UTC (rev 159793)
@@ -1,3 +1,13 @@
+2013-11-26  Andreas Kling  <akl...@apple.com>
+
+        RenderObject: Inline isBody() and isHR().
+        <https://webkit.org/b/124901>
+
+        Together these account for ~0.3% of samples on HTML5-8266.
+        Almost all of it is call overhead.
+
+        Reviewed by Anders Carlsson.
+
 2013-11-26  Bear Travis  <betra...@adobe.com>
 
         [CSS Shapes] Layout using [<box> || <shape>] value

Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (159792 => 159793)


--- trunk/Source/WebCore/rendering/RenderObject.cpp	2013-11-26 23:05:28 UTC (rev 159792)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2013-11-26 23:36:00 UTC (rev 159793)
@@ -142,16 +142,6 @@
     return false;
 }
 
-bool RenderObject::isBody() const
-{
-    return node() && node()->hasTagName(bodyTag);
-}
-
-bool RenderObject::isHR() const
-{
-    return node() && node()->hasTagName(hrTag);
-}
-
 bool RenderObject::isLegend() const
 {
     return node() && node()->hasTagName(legendTag);

Modified: trunk/Source/WebCore/rendering/RenderObject.h (159792 => 159793)


--- trunk/Source/WebCore/rendering/RenderObject.h	2013-11-26 23:05:28 UTC (rev 159792)
+++ trunk/Source/WebCore/rendering/RenderObject.h	2013-11-26 23:36:00 UTC (rev 159793)
@@ -368,8 +368,8 @@
     virtual bool isRenderScrollbarPart() const { return false; }
 
     bool isRoot() const { return document().documentElement() == &m_node; }
-    bool isBody() const;
-    bool isHR() const;
+    bool isBody() const { return node() && node()->hasTagName(HTMLNames::bodyTag); }
+    bool isHR() const { return node() && node()->hasTagName(HTMLNames::hrTag); }
     bool isLegend() const;
 
     bool isHTMLMarquee() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to