Title: [159813] trunk/Source/_javascript_Core
Revision
159813
Author
[email protected]
Date
2013-11-27 07:05:53 -0800 (Wed, 27 Nov 2013)

Log Message

JSActivation constructor should use NotNull placement new.
<https://webkit.org/b/124909>

Knock a null check outta the storage initialization loop.

Reviewed by Antti Koivisto.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (159812 => 159813)


--- trunk/Source/_javascript_Core/ChangeLog	2013-11-27 14:34:04 UTC (rev 159812)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-11-27 15:05:53 UTC (rev 159813)
@@ -1,3 +1,12 @@
+2013-11-27  Andreas Kling  <[email protected]>
+
+        JSActivation constructor should use NotNull placement new.
+        <https://webkit.org/b/124909>
+
+        Knock a null check outta the storage initialization loop.
+
+        Reviewed by Antti Koivisto.
+
 2013-11-26  Filip Pizlo  <[email protected]>
 
         Restructure global variable constant inference so that it could work for any kind of symbol table variable

Modified: trunk/Source/_javascript_Core/runtime/JSActivation.h (159812 => 159813)


--- trunk/Source/_javascript_Core/runtime/JSActivation.h	2013-11-27 14:34:04 UTC (rev 159812)
+++ trunk/Source/_javascript_Core/runtime/JSActivation.h	2013-11-27 15:05:53 UTC (rev 159813)
@@ -122,7 +122,7 @@
     WriteBarrier<Unknown>* storage = this->storage();
     size_t captureCount = symbolTable->captureCount();
     for (size_t i = 0; i < captureCount; ++i)
-        new(&storage[i]) WriteBarrier<Unknown>;
+        new (NotNull, &storage[i]) WriteBarrier<Unknown>;
 }
 
 JSActivation* asActivation(JSValue);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to