Title: [159848] trunk
- Revision
- 159848
- Author
- o...@webkit.org
- Date
- 2013-11-28 09:40:59 -0800 (Thu, 28 Nov 2013)
Log Message
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857
Patch by Laszlo Vidacs <l...@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.
Source/WebCore:
Use border spacing at the end of all sections.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
Skipped tests enabled.
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (159847 => 159848)
--- trunk/LayoutTests/ChangeLog 2013-11-28 16:55:28 UTC (rev 159847)
+++ trunk/LayoutTests/ChangeLog 2013-11-28 17:40:59 UTC (rev 159848)
@@ -1,3 +1,14 @@
+2013-11-28 Laszlo Vidacs <l...@inf.u-szeged.hu>
+
+ RenderTableSection Blink merge asserting
+ https://bugs.webkit.org/show_bug.cgi?id=124857
+
+ Reviewed by Csaba Osztrogonác.
+
+ Skipped tests enabled.
+
+ * TestExpectations:
+
2013-11-28 Michał Pakuła vel Rutka <m.pak...@samsung.com>
Unreviewed EFL gardening
Modified: trunk/LayoutTests/TestExpectations (159847 => 159848)
--- trunk/LayoutTests/TestExpectations 2013-11-28 16:55:28 UTC (rev 159847)
+++ trunk/LayoutTests/TestExpectations 2013-11-28 17:40:59 UTC (rev 159848)
@@ -69,7 +69,3 @@
# The spec is not clear if the MediaStream ended event should be fired if stop is called on each MediaStream's track
# Skipping it for now, then put it again when the spec decides it
fast/mediastream/MediaStream-onended.html [ Skip ]
-
-# Recent Blink merge has caused these tests to crash
-webkit.org/b/124857 tables/mozilla/bugs/bug46268-3.html [ Skip ]
-webkit.org/b/124857 tables/mozilla_expected_failures/bugs/bug46268-4.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (159847 => 159848)
--- trunk/Source/WebCore/ChangeLog 2013-11-28 16:55:28 UTC (rev 159847)
+++ trunk/Source/WebCore/ChangeLog 2013-11-28 17:40:59 UTC (rev 159848)
@@ -1,3 +1,15 @@
+2013-11-28 Laszlo Vidacs <l...@inf.u-szeged.hu>
+
+ RenderTableSection Blink merge asserting
+ https://bugs.webkit.org/show_bug.cgi?id=124857
+
+ Reviewed by Csaba Osztrogonác.
+
+ Use border spacing at the end of all sections.
+
+ * rendering/RenderTableSection.cpp:
+ (WebCore::RenderTableSection::calcRowLogicalHeight):
+
2013-11-28 Antti Koivisto <an...@apple.com>
Remove feature: CSS variables
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (159847 => 159848)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2013-11-28 16:55:28 UTC (rev 159847)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2013-11-28 17:40:59 UTC (rev 159848)
@@ -366,6 +366,8 @@
}
// Add the border-spacing to our final position.
+ // Use table border-spacing even in non-top sections
+ spacing = table()->vBorderSpacing();
m_rowPos[r + 1] += m_grid[r].rowRenderer ? spacing : 0;
m_rowPos[r + 1] = std::max(m_rowPos[r + 1], m_rowPos[r]);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
