[webkit-changes] [159882] trunk/Source/WebKit2

[commit-queue]

Title: [159882] trunk/Source/WebKit2

Revision

159882

Author

commit-qu...@webkit.org

Date

2013-11-29 20:13:42 -0800 (Fri, 29 Nov 2013)

Log Message

Fix build warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125012

Patch by Tibor Meszaros <mti...@inf.u-szeged.hu> on 2013-11-29
Reviewed by Anders Carlsson.

fix unused parameter warnings in the following files:

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::SocketEventSource::eventCallback):
* Shared/API/c/WKDeprecatedFunctions.cpp:
(WKArrayIsMutable):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

Modified Paths

• trunk/Source/WebKit2/ChangeLog
• trunk/Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp
• trunk/Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp
• trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
• trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

Diff

Modified: trunk/Source/WebKit2/ChangeLog (159881 => 159882)

--- trunk/Source/WebKit2/ChangeLog	2013-11-30 02:04:12 UTC (rev 159881)
+++ trunk/Source/WebKit2/ChangeLog	2013-11-30 04:13:42 UTC (rev 159882)
@@ -1,3 +1,23 @@
+2013-11-29  Tibor Meszaros  <mti...@inf.u-szeged.hu>
+
+        Fix build warnings in WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=125012
+
+        Reviewed by Anders Carlsson.
+
+        fix unused parameter warnings in the following files:
+
+        * Platform/gtk/WorkQueueGtk.cpp:
+        (WorkQueue::SocketEventSource::eventCallback):
+        * Shared/API/c/WKDeprecatedFunctions.cpp:
+        (WKArrayIsMutable):
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::unavailablePluginButtonClicked):
+        (WebKit::WebChromeClient::didAddHeaderLayer):
+        (WebKit::WebChromeClient::didAddFooterLayer):
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
+
 2013-11-29  Sam Weinig  <s...@webkit.org>
 
         [Cocoa] Add a little template magic to the inline API::Object storage to remove the need for all the reinterpret_casts

Modified: trunk/Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp (159881 => 159882)

--- trunk/Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp	2013-11-30 02:04:12 UTC (rev 159881)
+++ trunk/Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp	2013-11-30 04:13:42 UTC (rev 159882)
@@ -100,7 +100,7 @@
         return condition & m_condition;
     }
 
-    static gboolean eventCallback(GSocket* socket, GIOCondition condition, SocketEventSource* eventSource)
+    static gboolean eventCallback(GSocket*, GIOCondition condition, SocketEventSource* eventSource)
     {
         ASSERT(eventSource);
 

Modified: trunk/Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp (159881 => 159882)

--- trunk/Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp	2013-11-30 02:04:12 UTC (rev 159881)
+++ trunk/Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp	2013-11-30 04:13:42 UTC (rev 159882)
@@ -37,7 +37,7 @@
 #endif
 }
 
-bool WKArrayIsMutable(WKArrayRef array)
+bool WKArrayIsMutable(WKArrayRef)
 {
     return false;
 }

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp (159881 => 159882)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp	2013-11-30 02:04:12 UTC (rev 159881)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp	2013-11-30 04:13:42 UTC (rev 159882)
@@ -549,6 +549,9 @@
     if (!pluginspageAttributeURL.protocolIsInHTTPFamily())
         pluginspageAttributeURL = URL();
     m_page->send(Messages::WebPageProxy::UnavailablePluginButtonClicked(pluginUnavailabilityReason, pluginElement->serviceType(), pluginURLString, pluginspageAttributeURL.string(), frameURLString, pageURLString));
+#else
+    UNUSED_PARAM(element);
+    UNUSED_PARAM(pluginUnavailabilityReason);
 #endif // ENABLE(NETSCAPE_PLUGIN_API)
 }
 
@@ -894,6 +897,8 @@
 #if ENABLE(RUBBER_BANDING)
     if (PageBanner* banner = m_page->headerPageBanner())
         banner->didAddParentLayer(headerParent);
+#else
+    UNUSED_PARAM(headerParent);
 #endif
 }
 
@@ -902,6 +907,8 @@
 #if ENABLE(RUBBER_BANDING)
     if (PageBanner* banner = m_page->footerPageBanner())
         banner->didAddParentLayer(footerParent);
+#else
+    UNUSED_PARAM(footerParent);
 #endif
 }
 

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (159881 => 159882)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2013-11-30 02:04:12 UTC (rev 159881)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2013-11-30 04:13:42 UTC (rev 159882)
@@ -1384,6 +1384,10 @@
     }
     return plugin.release();
 #else
+    UNUSED_PARAM(pluginSize);
+    UNUSED_PARAM(appletElement);
+    UNUSED_PARAM(paramNames);
+    UNUSED_PARAM(paramValues);
     return 0;
 #endif
 }

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes