Title: [159997] trunk/Tools
- Revision
- 159997
- Author
- [email protected]
- Date
- 2013-12-03 04:30:22 -0800 (Tue, 03 Dec 2013)
Log Message
Style Checker false pass.
https://bugs.webkit.org/show_bug.cgi?id=112456
Patch by Gergo Balogh <[email protected]> on 2013-12-03
Reviewed by Csaba Osztrogonác.
* Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
simple regex fix to check "No new tests (...)."
* Scripts/webkitpy/style/checkers/changelog_unittest.py:
(ChangeLogCheckerTest.test_no_new_tests):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (159996 => 159997)
--- trunk/Tools/ChangeLog 2013-12-03 10:29:47 UTC (rev 159996)
+++ trunk/Tools/ChangeLog 2013-12-03 12:30:22 UTC (rev 159997)
@@ -1,3 +1,16 @@
+2013-12-03 Gergo Balogh <[email protected]>
+
+ Style Checker false pass.
+ https://bugs.webkit.org/show_bug.cgi?id=112456
+
+ Reviewed by Csaba Osztrogonác.
+
+ * Scripts/webkitpy/style/checkers/changelog.py:
+ (ChangeLogChecker.check_entry):
+ simple regex fix to check "No new tests (...)."
+ * Scripts/webkitpy/style/checkers/changelog_unittest.py:
+ (ChangeLogCheckerTest.test_no_new_tests):
+
2013-12-02 Filip Pizlo <[email protected]>
run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/changelog.py (159996 => 159997)
--- trunk/Tools/Scripts/webkitpy/style/checkers/changelog.py 2013-12-03 10:29:47 UTC (rev 159996)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/changelog.py 2013-12-03 12:30:22 UTC (rev 159997)
@@ -65,11 +65,11 @@
"changelog/filechangedescriptionwhitespace", 5,
"Need whitespace between colon and description")
- # check for a lingering "No new tests. (OOPS!)" left over from prepare-changeLog.
+ # check for a lingering "No new tests (OOPS!)." left over from prepare-changeLog.
line_no = first_line_checked - 1
for line in entry_lines:
line_no = line_no + 1
- if match('\s*No new tests. \(OOPS!\)$', line):
+ if match('\s*No new tests \(OOPS!\)\.$', line):
self.handle_style_error(line_no,
"changelog/nonewtests", 5,
"You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.")
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py (159996 => 159997)
--- trunk/Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py 2013-12-03 10:29:47 UTC (rev 159996)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py 2013-12-03 12:30:22 UTC (rev 159997)
@@ -125,7 +125,7 @@
' ExampleBug\n'
' http://bugs.webkit.org/show_bug.cgi?id=12345\n'
'\n'
- ' No new tests. (OOPS!)\n'
+ ' No new tests (OOPS!).\n'
' * Source/Tools/random-script.py: Fixed')
def test_no_error(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
