Title: [160021] trunk/Source/WebCore
- Revision
- 160021
- Author
- [email protected]
- Date
- 2013-12-03 11:37:24 -0800 (Tue, 03 Dec 2013)
Log Message
Checking second-to-last bit in address is a typo
https://bugs.webkit.org/show_bug.cgi?id=125162
Patch by Myles C. Maxfield <[email protected]> on 2013-12-03
Reviewed by Darin Adler.
After talking with the original author of this line,
is was a typo to make sure that the second-to-last bit
in an address is 0. Instead, we want to make sure that
the address is aligned to a 4-byte boundary
No behavior change, so no test is necessary
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (160020 => 160021)
--- trunk/Source/WebCore/ChangeLog 2013-12-03 19:36:06 UTC (rev 160020)
+++ trunk/Source/WebCore/ChangeLog 2013-12-03 19:37:24 UTC (rev 160021)
@@ -1,3 +1,20 @@
+2013-12-03 Myles C. Maxfield <[email protected]>
+
+ Checking second-to-last bit in address is a typo
+ https://bugs.webkit.org/show_bug.cgi?id=125162
+
+ Reviewed by Darin Adler.
+
+ After talking with the original author of this line,
+ is was a typo to make sure that the second-to-last bit
+ in an address is 0. Instead, we want to make sure that
+ the address is aligned to a 4-byte boundary
+
+ No behavior change, so no test is necessary
+
+ * platform/graphics/cg/ImageBufferCG.cpp:
+ (WebCore::ImageBuffer::ImageBuffer):
+
2013-12-03 Radu Stavila <[email protected]>
The overflow border of a relatively positioned element inside a region is not painted
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp (160020 => 160021)
--- trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp 2013-12-03 19:36:06 UTC (rev 160020)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp 2013-12-03 19:37:24 UTC (rev 160021)
@@ -158,7 +158,7 @@
if (!accelerateRendering) {
if (!tryFastCalloc(height.unsafeGet(), m_data.m_bytesPerRow.unsafeGet()).getValue(m_data.m_data))
return;
- ASSERT(!(reinterpret_cast<size_t>(m_data.m_data) & 2));
+ ASSERT(!(reinterpret_cast<intptr_t>(m_data.m_data) & 3));
m_data.m_bitmapInfo = kCGImageAlphaPremultipliedLast;
cgContext = adoptCF(CGBitmapContextCreate(m_data.m_data, width.unsafeGet(), height.unsafeGet(), 8, m_data.m_bytesPerRow.unsafeGet(), m_data.m_colorSpace, m_data.m_bitmapInfo));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
