Title: [160041] trunk/PerformanceTests
- Revision
- 160041
- Author
- [email protected]
- Date
- 2013-12-03 14:35:19 -0800 (Tue, 03 Dec 2013)
Log Message
[CSS Regions] Fix Layout/RegionsSelection.html in Mac platform
https://bugs.webkit.org/show_bug.cgi?id=124963
Reviewed by Ryosuke Niwa.
Layout/RegionsSelection.html introduced in r159488 was not working in
Mac platform because of it was trying to use mouse events out of the
window dimensions. Use collapse() and extend() methods from Selection
object to solve the issue.
* Layout/resources/regions.js: Use collapse() and extend() instead of
mouse events.
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (160040 => 160041)
--- trunk/PerformanceTests/ChangeLog 2013-12-03 22:32:20 UTC (rev 160040)
+++ trunk/PerformanceTests/ChangeLog 2013-12-03 22:35:19 UTC (rev 160041)
@@ -1,3 +1,18 @@
+2013-12-03 Manuel Rego Casasnovas <[email protected]>
+
+ [CSS Regions] Fix Layout/RegionsSelection.html in Mac platform
+ https://bugs.webkit.org/show_bug.cgi?id=124963
+
+ Reviewed by Ryosuke Niwa.
+
+ Layout/RegionsSelection.html introduced in r159488 was not working in
+ Mac platform because of it was trying to use mouse events out of the
+ window dimensions. Use collapse() and extend() methods from Selection
+ object to solve the issue.
+
+ * Layout/resources/regions.js: Use collapse() and extend() instead of
+ mouse events.
+
2013-11-27 Ryosuke Niwa <[email protected]>
Build fix after r159805.
Modified: trunk/PerformanceTests/Layout/resources/regions.js (160040 => 160041)
--- trunk/PerformanceTests/Layout/resources/regions.js 2013-12-03 22:32:20 UTC (rev 160040)
+++ trunk/PerformanceTests/Layout/resources/regions.js 2013-12-03 22:35:19 UTC (rev 160041)
@@ -88,23 +88,14 @@
};
}
- function mouseMoveToRegionCenter(region) {
- var rect = region.getBoundingClientRect();
- eventSender.mouseMoveTo(rect.left + (rect.width / 2), rect.top + (rect.height / 2));
- }
+ function performSelection(paragraphCount) {
+ var paragraphs = document.getElementsByClassName("contentParagraph");
+ var selection = getSelection();
- function performSelection(regionCount) {
- var regions = document.getElementsByClassName("region");
+ selection.collapse(paragraphs[0], 0);
- if (window.eventSender) {
- mouseMoveToRegionCenter(regions[0]);
- eventSender.mouseDown();
-
- for (var i = 1; i < regionCount; i++)
- mouseMoveToRegionCenter(regions[i]);
-
- eventSender.mouseUp();
- }
+ for (var i = 1; i < paragraphCount; i++)
+ selection.extend(paragraphs[i], 0);
}
function createRegionsSelectionTest(regionCount) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
