Title: [160048] trunk/Tools
Revision
160048
Author
[email protected]
Date
2013-12-03 15:20:08 -0800 (Tue, 03 Dec 2013)

Log Message

[Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
https://bugs.webkit.org/show_bug.cgi?id=125111

Patch by [email protected] <[email protected]> on 2013-12-03
Reviewed by Filip Pizlo.

Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.

* Scripts/run-_javascript_core-tests: Enable api test and stress test for WinCairo.
* Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (160047 => 160048)


--- trunk/Tools/ChangeLog	2013-12-03 23:19:40 UTC (rev 160047)
+++ trunk/Tools/ChangeLog	2013-12-03 23:20:08 UTC (rev 160048)
@@ -1,3 +1,15 @@
+2013-12-03  [email protected]  <[email protected]>
+
+        [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=125111
+
+        Reviewed by Filip Pizlo.
+
+        Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
+
+        * Scripts/run-_javascript_core-tests: Enable api test and stress test for WinCairo.
+        * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
+
 2013-12-03  Ryosuke Niwa  <[email protected]>
 
         Add a script to automatically configure a git clone

Modified: trunk/Tools/Scripts/run-_javascript_core-tests (160047 => 160048)


--- trunk/Tools/Scripts/run-_javascript_core-tests	2013-12-03 23:19:40 UTC (rev 160047)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2013-12-03 23:20:08 UTC (rev 160048)
@@ -69,13 +69,13 @@
 
 my $buildJSC = 1;
 
-my $runTestAPI = isAppleMacWebKit() || isAppleWinWebKit();
+my $runTestAPI = isAppleMacWebKit() || isAppleWinWebKit() || isWinCairo();
 
 my $runMozilla = 0;
 
 # FIXME: run-jsc-stress-tests should be ported to other platforms.
 # https://bugs.webkit.org/show_bug.cgi?id=120809
-my $runJSCStress = !isAppleWinWebKit() && !isWinCairo();
+my $runJSCStress = !isAppleWinWebKit();
 
 my $enableFTL = 0;
 

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (160047 => 160048)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2013-12-03 23:19:40 UTC (rev 160047)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2013-12-03 23:20:08 UTC (rev 160048)
@@ -275,7 +275,7 @@
         outp.puts "    " + plan.failCommand
         outp.puts "elif test -e ../#{Shellwords.shellescape(expectedFilename)}"
         outp.puts "then"
-        outp.puts "    diff -u ../#{Shellwords.shellescape(expectedFilename)} #{outputFilename} > #{diffFilename}"
+        outp.puts "    diff --strip-trailing-cr -u ../#{Shellwords.shellescape(expectedFilename)} #{outputFilename} > #{diffFilename}"
         outp.puts "    if [ $? -eq 0 ]"
         outp.puts "    then"
         outp.puts "    " + plan.successCommand
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to