Title: [160086] trunk/Tools
- Revision
- 160086
- Author
- [email protected]
- Date
- 2013-12-04 03:20:45 -0800 (Wed, 04 Dec 2013)
Log Message
check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
https://bugs.webkit.org/show_bug.cgi?id=124731
Patch by László Langó <[email protected]> on 2013-12-04
Reviewed by Zoltan Herczeg.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (160085 => 160086)
--- trunk/Tools/ChangeLog 2013-12-04 11:19:56 UTC (rev 160085)
+++ trunk/Tools/ChangeLog 2013-12-04 11:20:45 UTC (rev 160086)
@@ -1,5 +1,17 @@
2013-12-04 László Langó <[email protected]>
+ check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
+ https://bugs.webkit.org/show_bug.cgi?id=124731
+
+ Reviewed by Zoltan Herczeg.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ (check_spacing):
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
+
+2013-12-04 László Langó <[email protected]>
+
Remove codecs and os dependencies from filereader.py in webkitpy/style.
https://bugs.webkit.org/show_bug.cgi?id=124719
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (160085 => 160086)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2013-12-04 11:19:56 UTC (rev 160085)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2013-12-04 11:20:45 UTC (rev 160086)
@@ -1842,7 +1842,9 @@
# regexp takes linear rather than quadratic time.
if not search(r'<[^<]*,\s*$', line): # template params spill
matched = search(r'[^<>=!\s](<)[^<>=!\s]([^>]|->)*$', line)
- if matched:
+ # It is necessary to check this, because rvaule references can be in
+ # parameter packs (c++11 feature)
+ if matched and not search(r'&&\.\.\.', line):
error(line_number, 'whitespace/operators', 3,
'Missing spaces around %s' % matched.group(1))
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (160085 => 160086)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2013-12-04 11:19:56 UTC (rev 160085)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2013-12-04 11:20:45 UTC (rev 160086)
@@ -628,6 +628,8 @@
def test_rvaule_reference_at_end_of_line(self):
self.assert_lint('T&&', '')
+ def test_rvaule_reference_in_parameter_pack(self):
+ self.assert_lint('void requestCompleted(Arguments&&... arguments)', '')
class CppStyleTest(CppStyleTestBase):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
