[webkit-changes] [160157] trunk/Source/WebCore

[rniwa]

Title: [160157] trunk/Source/WebCore

Revision

160157

Author

rn...@webkit.org

Date

2013-12-04 19:57:12 -0800 (Wed, 04 Dec 2013)

Log Message

bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
https://bugs.webkit.org/show_bug.cgi?id=125208

Rubber-stamped by Anders Carlsson.

Address Darin's comment to use fastGetAttribute instead of getAttribute.

* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::vlinkColor):

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/html/HTMLDocument.cpp

Diff

Modified: trunk/Source/WebCore/ChangeLog (160156 => 160157)

--- trunk/Source/WebCore/ChangeLog	2013-12-05 03:42:15 UTC (rev 160156)
+++ trunk/Source/WebCore/ChangeLog	2013-12-05 03:57:12 UTC (rev 160157)
@@ -1,3 +1,19 @@
+2013-12-04  Ryosuke Niwa  <rn...@webkit.org>
+
+        bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
+        https://bugs.webkit.org/show_bug.cgi?id=125208
+
+        Rubber-stamped by Anders Carlsson.
+
+        Address Darin's comment to use fastGetAttribute instead of getAttribute.
+
+        * html/HTMLDocument.cpp:
+        (WebCore::HTMLDocument::bgColor):
+        (WebCore::HTMLDocument::fgColor):
+        (WebCore::HTMLDocument::alinkColor):
+        (WebCore::HTMLDocument::linkColor):
+        (WebCore::HTMLDocument::vlinkColor):
+
 2013-12-04  Brian J. Burg  <b...@cs.washington.edu>
 
         Consolidate various frame snapshot capabilities.

Modified: trunk/Source/WebCore/html/HTMLDocument.cpp (160156 => 160157)

--- trunk/Source/WebCore/html/HTMLDocument.cpp	2013-12-05 03:42:15 UTC (rev 160156)
+++ trunk/Source/WebCore/html/HTMLDocument.cpp	2013-12-05 03:57:12 UTC (rev 160157)
@@ -163,7 +163,7 @@
     HTMLElement* bodyElement = body();
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(bgcolorAttr);
+    return bodyElement->fastGetAttribute(bgcolorAttr);
 }
 
 void HTMLDocument::setBgColor(const String& value)
@@ -179,7 +179,7 @@
     HTMLElement* bodyElement = body();
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(textAttr);
+    return bodyElement->fastGetAttribute(textAttr);
 }
 
 void HTMLDocument::setFgColor(const String& value)
@@ -195,7 +195,7 @@
     HTMLElement* bodyElement = body();
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(alinkAttr);
+    return bodyElement->fastGetAttribute(alinkAttr);
 }
 
 void HTMLDocument::setAlinkColor(const String& value)
@@ -211,7 +211,7 @@
     HTMLElement* bodyElement = body();
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(linkAttr);
+    return bodyElement->fastGetAttribute(linkAttr);
 }
 
 void HTMLDocument::setLinkColor(const String& value)
@@ -227,7 +227,7 @@
     HTMLElement* bodyElement = body();
     if (!bodyElement || !isHTMLBodyElement(bodyElement))
         return emptyAtom;
-    return bodyElement->getAttribute(vlinkAttr);
+    return bodyElement->fastGetAttribute(vlinkAttr);
 }
 
 void HTMLDocument::setVlinkColor(const String& value)

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes