Log Message
[Win][64-bit] Hitting breakpoint assembler instruction in callToJavaScript. https://bugs.webkit.org/show_bug.cgi?id=125382
Patch by [email protected] <[email protected]> on 2013-12-07 Reviewed by Michael Saboff. The WinCairo results from run-_javascript_core-tests are the same as the WinCairo 32-bits results, when removing these breakpoints. * jit/JITStubsMSVC64.asm: Remove breakpoint instructions.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (160271 => 160272)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-07 14:54:15 UTC (rev 160271)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-07 16:33:39 UTC (rev 160272)
@@ -1,3 +1,14 @@
+2013-12-07 [email protected] <[email protected]>
+
+ [Win][64-bit] Hitting breakpoint assembler instruction in callToJavaScript.
+ https://bugs.webkit.org/show_bug.cgi?id=125382
+
+ Reviewed by Michael Saboff.
+
+ The WinCairo results from run-_javascript_core-tests are the same as the WinCairo 32-bits results, when removing these breakpoints.
+
+ * jit/JITStubsMSVC64.asm: Remove breakpoint instructions.
+
2013-12-06 Filip Pizlo <[email protected]>
FTL should support all of Branch/LogicalNot
Modified: trunk/Source/_javascript_Core/jit/JITStubsMSVC64.asm (160271 => 160272)
--- trunk/Source/_javascript_Core/jit/JITStubsMSVC64.asm 2013-12-07 14:54:15 UTC (rev 160271)
+++ trunk/Source/_javascript_Core/jit/JITStubsMSVC64.asm 2013-12-07 16:33:39 UTC (rev 160272)
@@ -32,10 +32,8 @@
_TEXT SEGMENT
callToJavaScript PROC
- ;; FIXME: This function has not been tested as the Win 64 port doesn't currently use the JIT.
- ;; It is believed to be an accurate adaptation of the assembly created by the llint stub of the
- ;; same name with changes for agrument register differences.
- int 3
+ ;; This function is believed to be an accurate adaptation of the assembly created by the llint stub of the
+ ;; same name with changes for argument register differences.
mov r10, qword ptr[rsp]
push rbp
mov rax, rbp ; Save previous frame pointer
@@ -132,10 +130,8 @@
callToJavaScript ENDP
callToNativeFunction PROC
- ;; FIXME: This function has not been tested as the Win 64 port doesn't currently use the JIT.
- ;; It is believed to be an accurate adaptation of the assembly created by the llint stub of the
- ;; same name with changes for agrument register differences.
- int 3
+ ;; This function is believed to be an accurate adaptation of the assembly created by the llint stub of the
+ ;; same name with changes for argument register differences.
mov r10, qword ptr[rsp]
push rbp
mov rax, rbp ; Save previous frame pointer
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
