Title: [160287] trunk/Tools
- Revision
- 160287
- Author
- zandober...@gmail.com
- Date
- 2013-12-08 08:51:28 -0800 (Sun, 08 Dec 2013)
Log Message
[gdb] Update printers for WTF::CString, JSC::JSString
https://bugs.webkit.org/show_bug.cgi?id=124600
Reviewed by Gustavo Noronha Silva.
Update the two printers after they fell behind the changes in implementation.
* gdb/webkit.py:
(WTFCStringPrinter.to_string):
(JSCJSStringPrinter.to_string):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (160286 => 160287)
--- trunk/Tools/ChangeLog 2013-12-08 16:50:01 UTC (rev 160286)
+++ trunk/Tools/ChangeLog 2013-12-08 16:51:28 UTC (rev 160287)
@@ -1,5 +1,18 @@
2013-12-08 Zan Dobersek <zdober...@igalia.com>
+ [gdb] Update printers for WTF::CString, JSC::JSString
+ https://bugs.webkit.org/show_bug.cgi?id=124600
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Update the two printers after they fell behind the changes in implementation.
+
+ * gdb/webkit.py:
+ (WTFCStringPrinter.to_string):
+ (JSCJSStringPrinter.to_string):
+
+2013-12-08 Zan Dobersek <zdober...@igalia.com>
+
[webkitpy] Add a WestonDriver unit test
https://bugs.webkit.org/show_bug.cgi?id=125408
Modified: trunk/Tools/gdb/webkit.py (160286 => 160287)
--- trunk/Tools/gdb/webkit.py 2013-12-08 16:50:01 UTC (rev 160286)
+++ trunk/Tools/gdb/webkit.py 2013-12-08 16:51:28 UTC (rev 160287)
@@ -115,10 +115,9 @@
class WTFCStringPrinter(StringPrinter):
"Print a WTF::CString"
def to_string(self):
- # The CString holds a buffer, which is a refptr to a WTF::CStringBuffer.
- data = ""
+ string = (self.val['m_buffer']['m_ptr'] + 1).cast(gdb.lookup_type('char').pointer())
length = self.val['m_buffer']['m_ptr']['m_length']
- return ''.join([chr((data + i).dereference()) for i in range(length)])
+ return lstring_to_string(string, length)
class WTFStringImplPrinter(StringPrinter):
@@ -164,7 +163,7 @@
if self.val['m_length'] == 0:
return ''
- return WTFStringImplPrinter(self.val['m_value']).to_string()
+ return WTFStringPrinter(self.val['m_value']).to_string()
class WebCoreQualifiedNamePrinter(StringPrinter):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
