Title: [160379] trunk
- Revision
- 160379
- Author
- mario.pr...@samsung.com
- Date
- 2013-12-10 12:11:18 -0800 (Tue, 10 Dec 2013)
Log Message
[ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
https://bugs.webkit.org/show_bug.cgi?id=125521
Reviewed by Chris Fleizach.
Source/WebCore:
Stop exposing alert dialogs as ATK_ROLE_DIALOG and do it as
ATK_ROLE_ALERT instead.
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
Update expected result in layout test.
* accessibility/aria-mappings-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (160378 => 160379)
--- trunk/LayoutTests/ChangeLog 2013-12-10 19:43:10 UTC (rev 160378)
+++ trunk/LayoutTests/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
@@ -1,3 +1,14 @@
+2013-12-10 Mario Sanchez Prada <mario.pr...@samsung.com>
+
+ [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
+ https://bugs.webkit.org/show_bug.cgi?id=125521
+
+ Reviewed by Chris Fleizach.
+
+ Update expected result in layout test.
+
+ * accessibility/aria-mappings-expected.txt:
+
2013-12-10 László Langó <la...@inf.u-szeged.hu>
PageConsole::addMessage should automatically determine column number alongside line number
Modified: trunk/LayoutTests/accessibility/aria-mappings-expected.txt (160378 => 160379)
--- trunk/LayoutTests/accessibility/aria-mappings-expected.txt 2013-12-10 19:43:10 UTC (rev 160378)
+++ trunk/LayoutTests/accessibility/aria-mappings-expected.txt 2013-12-10 20:11:18 UTC (rev 160379)
@@ -21,7 +21,7 @@
role="alertdialog" is a dialog which contains an alert message.
-Role for 'alertdialog' div is: AXRole: AXDialog
+Role for 'alertdialog' div is: AXRole: AXAlert
role="article" is a section of a page that consists of a composition that forms an independent part of a document, page, or site
Modified: trunk/Source/WebCore/ChangeLog (160378 => 160379)
--- trunk/Source/WebCore/ChangeLog 2013-12-10 19:43:10 UTC (rev 160378)
+++ trunk/Source/WebCore/ChangeLog 2013-12-10 20:11:18 UTC (rev 160379)
@@ -1,3 +1,16 @@
+2013-12-10 Mario Sanchez Prada <mario.pr...@samsung.com>
+
+ [ATK] Elements with role 'alertdialog' should be ATK_ROLE_ALERT
+ https://bugs.webkit.org/show_bug.cgi?id=125521
+
+ Reviewed by Chris Fleizach.
+
+ Stop exposing alert dialogs as ATK_ROLE_DIALOG and do it as
+ ATK_ROLE_ALERT instead.
+
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole):
+
2013-12-10 Brendan Long <b.l...@cablelabs.com>
[GTK][GStreamer] media/video-preload.html is flakily crashing on WK2
Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (160378 => 160379)
--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-10 19:43:10 UTC (rev 160378)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp 2013-12-10 20:11:18 UTC (rev 160379)
@@ -534,10 +534,10 @@
static AtkRole atkRole(AccessibilityRole role)
{
switch (role) {
+ case ApplicationAlertDialogRole:
case ApplicationAlertRole:
return ATK_ROLE_ALERT;
case ApplicationDialogRole:
- case ApplicationAlertDialogRole:
return ATK_ROLE_DIALOG;
case ApplicationStatusRole:
return ATK_ROLE_STATUSBAR;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
