Title: [160389] trunk/Source/WebCore
- Revision
- 160389
- Author
- commit-qu...@webkit.org
- Date
- 2013-12-10 14:28:06 -0800 (Tue, 10 Dec 2013)
Log Message
Clean up SVGScriptElement
https://bugs.webkit.org/show_bug.cgi?id=125527
Patch by Rob Buis <rob.b...@samsung.com> on 2013-12-10
Reviewed by Sam Weinig.
Rewrite to not store type in m_type and also remove type getter/setter.
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::parseAttribute):
(WebCore::SVGScriptElement::typeAttributeValue):
* svg/SVGScriptElement.h:
* svg/SVGScriptElement.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (160388 => 160389)
--- trunk/Source/WebCore/ChangeLog 2013-12-10 22:11:28 UTC (rev 160388)
+++ trunk/Source/WebCore/ChangeLog 2013-12-10 22:28:06 UTC (rev 160389)
@@ -1,3 +1,18 @@
+2013-12-10 Rob Buis <rob.b...@samsung.com>
+
+ Clean up SVGScriptElement
+ https://bugs.webkit.org/show_bug.cgi?id=125527
+
+ Reviewed by Sam Weinig.
+
+ Rewrite to not store type in m_type and also remove type getter/setter.
+
+ * svg/SVGScriptElement.cpp:
+ (WebCore::SVGScriptElement::parseAttribute):
+ (WebCore::SVGScriptElement::typeAttributeValue):
+ * svg/SVGScriptElement.h:
+ * svg/SVGScriptElement.idl:
+
2013-12-10 Laszlo Vidacs <l...@inf.u-szeged.hu>
Use std::array when computing MD5 checksum
Modified: trunk/Source/WebCore/svg/SVGScriptElement.cpp (160388 => 160389)
--- trunk/Source/WebCore/svg/SVGScriptElement.cpp 2013-12-10 22:11:28 UTC (rev 160388)
+++ trunk/Source/WebCore/svg/SVGScriptElement.cpp 2013-12-10 22:28:06 UTC (rev 160389)
@@ -76,10 +76,8 @@
return;
}
- if (name == SVGNames::typeAttr) {
- setType(value);
+ if (name == SVGNames::typeAttr)
return;
- }
if (name == HTMLNames::onerrorAttr) {
setAttributeEventListener(eventNames().errorEvent, name, value);
@@ -143,16 +141,6 @@
SVGExternalResourcesRequired::finishParsingChildren();
}
-String SVGScriptElement::type() const
-{
- return m_type;
-}
-
-void SVGScriptElement::setType(const String& type)
-{
- m_type = type;
-}
-
void SVGScriptElement::addSubresourceAttributeURLs(ListHashSet<URL>& urls) const
{
SVGElement::addSubresourceAttributeURLs(urls);
@@ -172,7 +160,7 @@
String SVGScriptElement::typeAttributeValue() const
{
- return type();
+ return fastGetAttribute(SVGNames::typeAttr).string();
}
String SVGScriptElement::languageAttributeValue() const
Modified: trunk/Source/WebCore/svg/SVGScriptElement.h (160388 => 160389)
--- trunk/Source/WebCore/svg/SVGScriptElement.h 2013-12-10 22:11:28 UTC (rev 160388)
+++ trunk/Source/WebCore/svg/SVGScriptElement.h 2013-12-10 22:28:06 UTC (rev 160389)
@@ -38,8 +38,6 @@
public:
static PassRefPtr<SVGScriptElement> create(const QualifiedName&, Document&, bool wasInsertedByParser);
- String type() const;
- void setType(const String&);
private:
SVGScriptElement(const QualifiedName&, Document&, bool wasInsertedByParser, bool alreadyStarted);
@@ -83,7 +81,6 @@
DECLARE_ANIMATED_BOOLEAN(ExternalResourcesRequired, externalResourcesRequired)
END_DECLARE_ANIMATED_PROPERTIES
- String m_type;
Timer<SVGElement> m_svgLoadEventTimer;
};
Modified: trunk/Source/WebCore/svg/SVGScriptElement.idl (160388 => 160389)
--- trunk/Source/WebCore/svg/SVGScriptElement.idl 2013-12-10 22:11:28 UTC (rev 160388)
+++ trunk/Source/WebCore/svg/SVGScriptElement.idl 2013-12-10 22:28:06 UTC (rev 160389)
@@ -26,7 +26,7 @@
[
Conditional=SVG
] interface SVGScriptElement : SVGElement {
- [TreatNullAs=NullString] attribute DOMString type;
+ [TreatNullAs=NullString, Reflect] attribute DOMString type;
};
SVGScriptElement implements SVGExternalResourcesRequired;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
