Title: [160394] trunk/Source/_javascript_Core
- Revision
- 160394
- Author
- [email protected]
- Date
- 2013-12-10 15:36:09 -0800 (Tue, 10 Dec 2013)
Log Message
Get rid of forward exit in GetByVal on Uint32Array
https://bugs.webkit.org/show_bug.cgi?id=125543
Reviewed by Oliver Hunt.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (160393 => 160394)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-10 23:30:22 UTC (rev 160393)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-10 23:36:09 UTC (rev 160394)
@@ -1,3 +1,15 @@
+2013-12-10 Filip Pizlo <[email protected]>
+
+ Get rid of forward exit in GetByVal on Uint32Array
+ https://bugs.webkit.org/show_bug.cgi?id=125543
+
+ Reviewed by Oliver Hunt.
+
+ * dfg/DFGSpeculativeJIT.cpp:
+ (JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
+ * ftl/FTLLowerDFGToLLVM.cpp:
+ (JSC::FTL::LowerDFGToLLVM::compileGetByVal):
+
2013-12-10 Balazs Kilvady <[email protected]>
[MIPS] Redundant instructions in code generated from offlineasm.
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (160393 => 160394)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2013-12-10 23:30:22 UTC (rev 160393)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2013-12-10 23:36:09 UTC (rev 160394)
@@ -2394,7 +2394,7 @@
ASSERT(elementSize(type) == 4 && !isSigned(type));
if (node->shouldSpeculateInt32()) {
- forwardSpeculationCheck(Overflow, JSValueRegs(), 0, m_jit.branch32(MacroAssembler::LessThan, resultReg, TrustedImm32(0)), ValueRecovery::uint32InGPR(resultReg));
+ speculationCheck(Overflow, JSValueRegs(), 0, m_jit.branch32(MacroAssembler::LessThan, resultReg, TrustedImm32(0)));
int32Result(resultReg, node);
return;
}
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (160393 => 160394)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2013-12-10 23:30:22 UTC (rev 160393)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp 2013-12-10 23:36:09 UTC (rev 160394)
@@ -1639,9 +1639,8 @@
}
if (m_node->shouldSpeculateInt32()) {
- speculateForward(
- Overflow, noValue(), 0, m_out.lessThan(result, m_out.int32Zero),
- uInt32Value(result));
+ speculate(
+ Overflow, noValue(), 0, m_out.lessThan(result, m_out.int32Zero));
setInt32(result);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
