Title: [160470] branches/jsCStack/Source/_javascript_Core
Revision
160470
Author
[email protected]
Date
2013-12-11 18:23:19 -0800 (Wed, 11 Dec 2013)

Log Message

Introducing MaxFrameExtentForSlowPathCall.h.
https://bugs.webkit.org/show_bug.cgi?id=125609.

Reviewed by Mark Hahnenberg.

* assembler/MaxFrameExtentForSlowPath.h: Added.
- defines a constant for the max amount of stack space that we need to
  allocate (per JS frame) for holding the outgoing args for slow path
  calls from JS to C functions.

Modified Paths

Added Paths

Diff

Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (160469 => 160470)


--- branches/jsCStack/Source/_javascript_Core/ChangeLog	2013-12-12 01:59:00 UTC (rev 160469)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog	2013-12-12 02:23:19 UTC (rev 160470)
@@ -1,3 +1,15 @@
+2013-12-11  Mark Lam  <[email protected]>
+
+        Introducing MaxFrameExtentForSlowPathCall.h.
+        https://bugs.webkit.org/show_bug.cgi?id=125609.
+
+        Reviewed by Mark Hahnenberg.
+
+        * assembler/MaxFrameExtentForSlowPath.h: Added.
+        - defines a constant for the max amount of stack space that we need to
+          allocate (per JS frame) for holding the outgoing args for slow path
+          calls from JS to C functions.
+
 2013-12-11  Michael Saboff  <[email protected]>
 
         CStack Branch: enable use of DFG for simple _javascript_

Added: branches/jsCStack/Source/_javascript_Core/assembler/MaxFrameExtentForSlowPathCall.h (0 => 160470)


--- branches/jsCStack/Source/_javascript_Core/assembler/MaxFrameExtentForSlowPathCall.h	                        (rev 0)
+++ branches/jsCStack/Source/_javascript_Core/assembler/MaxFrameExtentForSlowPathCall.h	2013-12-12 02:23:19 UTC (rev 160470)
@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2013 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
+ */
+
+#ifndef MaxFrameExtentForSlowPathCall_h
+#define MaxFrameExtentForSlowPathCall_h
+
+namespace JSC {
+
+// The maxFrameExtentForSlowPathCall is the max amount of stack space (in bytes)
+// that can be used for outgoing args when calling a slow path C function
+// from JS code.
+
+#if ENABLE(LLINT_C_LOOP) || USE(SEPARATE_C_AND_JS_STACK)
+static const size_t maxFrameExtentForSlowPathCall = 0;
+
+#elif CPU(X86_64) && OS(WINDOWS)
+// 4 args in registers, but stack space needs to be allocated for all args.
+static const size_t maxFrameExtentForSlowPathCall = 48;
+
+#elif CPU(X86_64)
+// All args in registers.
+static const size_t maxFrameExtentForSlowPathCall = 0;
+
+#elif CPU(X86)
+// 6 args on stack (24 bytes) + 8 bytes to align the stack.
+static const size_t maxFrameExtentForSlowPathCall = 32;
+
+#elif CPU(ARM64)
+// All args in registers.
+static const size_t maxFrameExtentForSlowPathCall = 0;
+
+#elif CPU(ARM) || CPU(ARM_TRADITIONAL) || CPU(ARM_THUMB2)
+// First four args in registers, remaining 4 args on stack.
+static const size_t maxFrameExtentForSlowPathCall = 16;
+
+#elif CPU(SH4)
+// First four args in registers, remaining 4 args on stack.
+static const size_t maxFrameExtentForSlowPathCall = 16;
+
+#elif CPU(MIPS)
+// Though args are in registers, there need to be space on the stack for all args.
+static const size_t maxFrameExtentForSlowPathCall = 32;
+
+#else
+#error "Unsupported CPU: need value for maxFrameExtentForSlowPathCall"
+
+#endif
+
+} // namespace JSC
+
+#endif // MaxFrameExtentForSlowPathCall_h
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to