Title: [160498] trunk/Source/WebCore
- Revision
- 160498
- Author
- [email protected]
- Date
- 2013-12-12 11:22:55 -0800 (Thu, 12 Dec 2013)
Log Message
[Mac] Stop not caching HTTP resources with "Vary" header in response.
<https://webkit.org/b/125483>
<rdar://problem/11781097>
Remove the workaround preventing resources with the "Vary" header
from going into cache, as the CFNetwork cache has supported this
for quite a while now.
31.5 MB progression on Membuster3, because we can now mmap those
resources from disk once they are in the cache.
We keep the workaround on PLATFORM(WIN) for now.
Reviewed by Antti Koivisto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (160497 => 160498)
--- trunk/Source/WebCore/ChangeLog 2013-12-12 19:21:09 UTC (rev 160497)
+++ trunk/Source/WebCore/ChangeLog 2013-12-12 19:22:55 UTC (rev 160498)
@@ -1,3 +1,20 @@
+2013-12-12 Andreas Kling <[email protected]>
+
+ [Mac] Stop not caching HTTP resources with "Vary" header in response.
+ <https://webkit.org/b/125483>
+ <rdar://problem/11781097>
+
+ Remove the workaround preventing resources with the "Vary" header
+ from going into cache, as the CFNetwork cache has supported this
+ for quite a while now.
+
+ 31.5 MB progression on Membuster3, because we can now mmap those
+ resources from disk once they are in the cache.
+
+ We keep the workaround on PLATFORM(WIN) for now.
+
+ Reviewed by Antti Koivisto.
+
2013-12-12 Sam Weinig <[email protected]>
Replace uses of WTF::BitArray with std::bitset
Modified: trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm (160497 => 160498)
--- trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm 2013-12-12 19:21:09 UTC (rev 160497)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm 2013-12-12 19:22:55 UTC (rev 160498)
@@ -255,12 +255,6 @@
if (!m_handle || !m_handle->client())
return nil;
- // Workaround for <rdar://problem/6300990> Caching does not respect Vary HTTP header.
- // FIXME: WebCore cache has issues with Vary, too (bug 58797, bug 71509).
- if ([[cachedResponse response] isKindOfClass:[NSHTTPURLResponse class]]
- && [[(NSHTTPURLResponse *)[cachedResponse response] allHeaderFields] objectForKey:@"Vary"])
- return nil;
-
return m_handle->client()->willCacheResponse(m_handle, cachedResponse);
}
Modified: trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (160497 => 160498)
--- trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm 2013-12-12 19:21:09 UTC (rev 160497)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm 2013-12-12 19:22:55 UTC (rev 160498)
@@ -369,15 +369,6 @@
return;
}
- // Workaround for <rdar://problem/6300990> Caching does not respect Vary HTTP header.
- // FIXME: WebCore cache has issues with Vary, too (bug 58797, bug 71509).
- if ([[cachedResponse response] isKindOfClass:[NSHTTPURLResponse class]]
- && [[(NSHTTPURLResponse *)[cachedResponse response] allHeaderFields] objectForKey:@"Vary"]) {
- m_cachedResponseResult = nullptr;
- dispatch_semaphore_signal(m_semaphore);
- return;
- }
-
m_handle->client()->willCacheResponseAsync(m_handle, cachedResponse);
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
