Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (160682 => 160683)
--- trunk/Source/_javascript_Core/ChangeLog 2013-12-17 01:36:50 UTC (rev 160682)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-12-17 02:00:06 UTC (rev 160683)
@@ -1,3 +1,15 @@
+2013-12-16 Joseph Pecoraro <[email protected]>
+
+ Fix some whitespace issues in inspector code
+ https://bugs.webkit.org/show_bug.cgi?id=125814
+
+ Reviewed by Darin Adler.
+
+ * inspector/protocol/Debugger.json:
+ * inspector/protocol/Runtime.json:
+ * inspector/scripts/CodeGeneratorInspector.py:
+ (Generator.process_command):
+
2013-12-16 Mark Hahnenberg <[email protected]>
Add some missing functions to MacroAssembler
Modified: trunk/Source/_javascript_Core/inspector/protocol/Debugger.json (160682 => 160683)
--- trunk/Source/_javascript_Core/inspector/protocol/Debugger.json 2013-12-17 01:36:50 UTC (rev 160682)
+++ trunk/Source/_javascript_Core/inspector/protocol/Debugger.json 2013-12-17 02:00:06 UTC (rev 160683)
@@ -240,7 +240,7 @@
{ "name": "includeCommandLineAPI", "type": "boolean", "optional": true, "description": "Specifies whether command line API should be available to the evaluated _expression_, defaults to false." },
{ "name": "doNotPauseOnExceptionsAndMuteConsole", "type": "boolean", "optional": true, "description": "Specifies whether evaluation should stop on exceptions and mute console. Overrides setPauseOnException state." },
{ "name": "returnByValue", "type": "boolean", "optional": true, "description": "Whether the result is expected to be a JSON object that should be sent by value." },
- { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
+ { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
],
"returns": [
{ "name": "result", "$ref": "Runtime.RemoteObject", "description": "Object wrapper for the evaluation result." },
Modified: trunk/Source/_javascript_Core/inspector/protocol/Runtime.json (160682 => 160683)
--- trunk/Source/_javascript_Core/inspector/protocol/Runtime.json 2013-12-17 01:36:50 UTC (rev 160682)
+++ trunk/Source/_javascript_Core/inspector/protocol/Runtime.json 2013-12-17 02:00:06 UTC (rev 160683)
@@ -135,7 +135,7 @@
{ "name": "doNotPauseOnExceptionsAndMuteConsole", "type": "boolean", "optional": true, "description": "Specifies whether evaluation should stop on exceptions and mute console. Overrides setPauseOnException state." },
{ "name": "contextId", "$ref": "Runtime.ExecutionContextId", "optional": true, "description": "Specifies in which isolated context to perform evaluation. Each content script lives in an isolated context and this parameter may be used to specify one of those contexts. If the parameter is omitted or 0 the evaluation will be performed in the context of the inspected page." },
{ "name": "returnByValue", "type": "boolean", "optional": true, "description": "Whether the result is expected to be a JSON object that should be sent by value." },
- { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
+ { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
],
"returns": [
{ "name": "result", "$ref": "RemoteObject", "description": "Evaluation result." },
@@ -151,7 +151,7 @@
{ "name": "arguments", "type": "array", "items": { "$ref": "CallArgument", "description": "Call argument." }, "optional": true, "description": "Call arguments. All call arguments must belong to the same _javascript_ world as the target object." },
{ "name": "doNotPauseOnExceptionsAndMuteConsole", "type": "boolean", "optional": true, "description": "Specifies whether function call should stop on exceptions and mute console. Overrides setPauseOnException state." },
{ "name": "returnByValue", "type": "boolean", "optional": true, "description": "Whether the result is expected to be a JSON object which should be sent by value." },
- { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
+ { "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
],
"returns": [
{ "name": "result", "$ref": "RemoteObject", "description": "Call result." },
Modified: trunk/Source/_javascript_Core/inspector/scripts/CodeGeneratorInspector.py (160682 => 160683)
--- trunk/Source/_javascript_Core/inspector/scripts/CodeGeneratorInspector.py 2013-12-17 01:36:50 UTC (rev 160682)
+++ trunk/Source/_javascript_Core/inspector/scripts/CodeGeneratorInspector.py 2013-12-17 02:00:06 UTC (rev 160683)
@@ -2055,7 +2055,7 @@
else:
dispatcher_if_chain.append(" else if (method == \"%s\")" % json_command_name)
dispatcher_if_chain.append(" %s(callId, *message.get());" % json_command_name)
- dispatcher_commands_list.append(" { \"%s\", &%s::%s }," % (json_command_name, dispatcher_name, json_command_name))
+ dispatcher_commands_list.append(" { \"%s\", &%s::%s }," % (json_command_name, dispatcher_name, json_command_name))
method_in_params_handling = []
method_dispatch_handling = []
Modified: trunk/Source/WebCore/ChangeLog (160682 => 160683)
--- trunk/Source/WebCore/ChangeLog 2013-12-17 01:36:50 UTC (rev 160682)
+++ trunk/Source/WebCore/ChangeLog 2013-12-17 02:00:06 UTC (rev 160683)
@@ -1,5 +1,16 @@
2013-12-16 Joseph Pecoraro <[email protected]>
+ Fix some whitespace issues in inspector code
+ https://bugs.webkit.org/show_bug.cgi?id=125814
+
+ Reviewed by Darin Adler.
+
+ * inspector/protocol/DOM.json:
+ * inspector/protocol/DOMStorage.json:
+ * inspector/protocol/Timeline.json:
+
+2013-12-16 Joseph Pecoraro <[email protected]>
+
Web Inspector: Use JSC::SourceID and JSC::BreakpointID instead of WebCore dups
https://bugs.webkit.org/show_bug.cgi?id=125818
Modified: trunk/Source/WebCore/inspector/protocol/DOM.json (160682 => 160683)
--- trunk/Source/WebCore/inspector/protocol/DOM.json 2013-12-17 01:36:50 UTC (rev 160682)
+++ trunk/Source/WebCore/inspector/protocol/DOM.json 2013-12-17 02:00:06 UTC (rev 160683)
@@ -280,7 +280,7 @@
{
"name": "highlightNode",
"parameters": [
- { "name": "highlightConfig", "$ref": "HighlightConfig", "description": "A descriptor for the highlight appearance." },
+ { "name": "highlightConfig", "$ref": "HighlightConfig", "description": "A descriptor for the highlight appearance." },
{ "name": "nodeId", "$ref": "NodeId", "optional": true, "description": "Identifier of the node to highlight." },
{ "name": "objectId", "$ref": "Runtime.RemoteObjectId", "optional": true, "description": "_javascript_ object id of the node to be highlighted." }
],
Modified: trunk/Source/WebCore/inspector/protocol/DOMStorage.json (160682 => 160683)
--- trunk/Source/WebCore/inspector/protocol/DOMStorage.json 2013-12-17 01:36:50 UTC (rev 160682)
+++ trunk/Source/WebCore/inspector/protocol/DOMStorage.json 2013-12-17 02:00:06 UTC (rev 160683)
@@ -56,20 +56,20 @@
{
"name": "domStorageItemsCleared",
"parameters": [
- { "name": "storageId", "$ref": "StorageId" }
+ { "name": "storageId", "$ref": "StorageId" }
]
},
{
"name": "domStorageItemRemoved",
"parameters": [
- { "name": "storageId", "$ref": "StorageId" },
+ { "name": "storageId", "$ref": "StorageId" },
{ "name": "key", "type": "string" }
]
},
{
"name": "domStorageItemAdded",
"parameters": [
- { "name": "storageId", "$ref": "StorageId" },
+ { "name": "storageId", "$ref": "StorageId" },
{ "name": "key", "type": "string" },
{ "name": "newValue", "type": "string" }
]
@@ -77,7 +77,7 @@
{
"name": "domStorageItemUpdated",
"parameters": [
- { "name": "storageId", "$ref": "StorageId" },
+ { "name": "storageId", "$ref": "StorageId" },
{ "name": "key", "type": "string" },
{ "name": "oldValue", "type": "string" },
{ "name": "newValue", "type": "string" }
Modified: trunk/Source/WebCore/inspector/protocol/Timeline.json (160682 => 160683)
--- trunk/Source/WebCore/inspector/protocol/Timeline.json 2013-12-17 01:36:50 UTC (rev 160682)
+++ trunk/Source/WebCore/inspector/protocol/Timeline.json 2013-12-17 02:00:06 UTC (rev 160683)
@@ -26,8 +26,8 @@
{ "name": "thread", "type": "string", "optional": true, "description": "If present, identifies the thread that produced the event." },
{ "name": "data", "type": "object", "description": "Event data." },
{ "name": "children", "type": "array", "optional": true, "items": { "$ref": "TimelineEvent" }, "description": "Nested records." },
- { "name": "counters", "$ref": "DOMCounters", "optional": true, "description": "Current values of DOM counters." },
- { "name": "usedHeapSize", "type": "integer", "optional": true, "description": "Current size of JS heap." }
+ { "name": "counters", "$ref": "DOMCounters", "optional": true, "description": "Current values of DOM counters." },
+ { "name": "usedHeapSize", "type": "integer", "optional": true, "description": "Current size of JS heap." }
],
"description": "Timeline record contains information about the recorded activity."
}
@@ -37,7 +37,7 @@
"name": "start",
"parameters": [
{ "name": "maxCallStackDepth", "optional": true, "type": "integer", "description": "Samples _javascript_ stack traces up to <code>maxCallStackDepth</code>, defaults to 5." },
- { "name": "includeDomCounters", "optional": true, "type": "boolean", "description": "Whether DOM counters data should be included into timeline events." }
+ { "name": "includeDomCounters", "optional": true, "type": "boolean", "description": "Whether DOM counters data should be included into timeline events." }
],
"description": "Starts capturing instrumentation events."
},
