Title: [160715] trunk
- Revision
- 160715
- Author
- [email protected]
- Date
- 2013-12-17 10:38:46 -0800 (Tue, 17 Dec 2013)
Log Message
REGRESSION(r159166?): fast/block/float/float-with-fractional-height-vertical-lr.html, fast/block/float/float-with-fractional-height.html are failing
https://bugs.webkit.org/show_bug.cgi?id=124506
Reviewed by Dirk Schulze.
Source/WebCore:
Floor the endpoints of the floating object interval to keep the old
behavior until a better fix can be created.
No new tests, fixes regression in existing tests.
* rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::intervalForFloatingObject):
LayoutTests:
Remove lines for tests that have been fixed by this patch.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (160714 => 160715)
--- trunk/LayoutTests/ChangeLog 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/LayoutTests/ChangeLog 2013-12-17 18:38:46 UTC (rev 160715)
@@ -1,3 +1,15 @@
+2013-12-17 Bem Jones-Bey <[email protected]>
+
+ REGRESSION(r159166?): fast/block/float/float-with-fractional-height-vertical-lr.html, fast/block/float/float-with-fractional-height.html are failing
+ https://bugs.webkit.org/show_bug.cgi?id=124506
+
+ Reviewed by Dirk Schulze.
+
+ Remove lines for tests that have been fixed by this patch.
+
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+
2013-12-17 Mario Sanchez Prada <[email protected]>
[ATK] Expose accessibility objects for <dl>, <dt> and <dd>
Modified: trunk/LayoutTests/platform/efl/TestExpectations (160714 => 160715)
--- trunk/LayoutTests/platform/efl/TestExpectations 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2013-12-17 18:38:46 UTC (rev 160715)
@@ -1730,9 +1730,6 @@
webkit.org/b/118126 css3/flexbox/image-percent-max-height.html [ ImageOnlyFailure ]
webkit.org/b/118126 fast/flexbox/image-percent-max-height.html [ ImageOnlyFailure ]
-webkit.org/b/124506 fast/block/float/float-with-fractional-height-vertical-lr.html [ ImageOnlyFailure ]
-webkit.org/b/124506 fast/block/float/float-with-fractional-height.html [ ImageOnlyFailure ]
-
webkit.org/b/124656 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ]
webkit.org/b/124657 fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (160714 => 160715)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-12-17 18:38:46 UTC (rev 160715)
@@ -1492,9 +1492,6 @@
webkit.org/b/124509 media/video-controls-captions-trackmenu-hide-on-click-outside.html [ Failure ]
webkit.org/b/124509 media/video-controls-captions-trackmenu-hide-on-click.html [ Failure ]
-webkit.org/b/124506 fast/block/float/float-with-fractional-height-vertical-lr.html [ ImageOnlyFailure ]
-webkit.org/b/124506 fast/block/float/float-with-fractional-height.html [ ImageOnlyFailure ]
-
webkit.org/b/124565 fast/multicol/seamless-flowed-through-columns.html [ ImageOnlyFailure ]
webkit.org/b/124566 fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (160714 => 160715)
--- trunk/Source/WebCore/ChangeLog 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/Source/WebCore/ChangeLog 2013-12-17 18:38:46 UTC (rev 160715)
@@ -1,3 +1,18 @@
+2013-12-17 Bem Jones-Bey <[email protected]>
+
+ REGRESSION(r159166?): fast/block/float/float-with-fractional-height-vertical-lr.html, fast/block/float/float-with-fractional-height.html are failing
+ https://bugs.webkit.org/show_bug.cgi?id=124506
+
+ Reviewed by Dirk Schulze.
+
+ Floor the endpoints of the floating object interval to keep the old
+ behavior until a better fix can be created.
+
+ No new tests, fixes regression in existing tests.
+
+ * rendering/FloatingObjects.cpp:
+ (WebCore::FloatingObjects::intervalForFloatingObject):
+
2013-12-17 Alex Christensen <[email protected]>
[Win] Visual Studio workaround for compiling WebGL.
Modified: trunk/Source/WebCore/rendering/FloatingObjects.cpp (160714 => 160715)
--- trunk/Source/WebCore/rendering/FloatingObjects.cpp 2013-12-17 18:25:27 UTC (rev 160714)
+++ trunk/Source/WebCore/rendering/FloatingObjects.cpp 2013-12-17 18:38:46 UTC (rev 160715)
@@ -280,9 +280,11 @@
FloatingObjectInterval FloatingObjects::intervalForFloatingObject(FloatingObject* floatingObject)
{
+ // FIXME The endpoints of the floating object interval shouldn't need to be
+ // floored. See http://wkb.ug/125831 for more details.
if (m_horizontalWritingMode)
- return FloatingObjectInterval(floatingObject->frameRect().y(), floatingObject->frameRect().maxY(), floatingObject);
- return FloatingObjectInterval(floatingObject->frameRect().x(), floatingObject->frameRect().maxX(), floatingObject);
+ return FloatingObjectInterval(floatingObject->frameRect().y().floor(), floatingObject->frameRect().maxY().floor(), floatingObject);
+ return FloatingObjectInterval(floatingObject->frameRect().x().floor(), floatingObject->frameRect().maxX().floor(), floatingObject);
}
void FloatingObjects::addPlacedObject(FloatingObject* floatingObject)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
