Title: [160747] trunk/Source/WebCore
- Revision
- 160747
- Author
- [email protected]
- Date
- 2013-12-17 20:18:02 -0800 (Tue, 17 Dec 2013)
Log Message
Remove dead code for reflected attributes from audio, video, and track elements
https://bugs.webkit.org/show_bug.cgi?id=125838
Reviewed by Eric Carlson.
Merge https://chromium.googlesource.com/chromium/blink/+/310514e2f0fd934975b841d463bad0cd62e6fd64
Where [Reflect] is used in the IDL, the getters and setters in C++ are
only for internal convenience, and these were unused.
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
* html/HTMLTrackElement.cpp:
* html/HTMLTrackElement.h:
* html/HTMLVideoElement.cpp:
* html/HTMLVideoElement.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (160746 => 160747)
--- trunk/Source/WebCore/ChangeLog 2013-12-18 03:45:57 UTC (rev 160746)
+++ trunk/Source/WebCore/ChangeLog 2013-12-18 04:18:02 UTC (rev 160747)
@@ -1,3 +1,22 @@
+2013-12-17 Ryosuke Niwa <[email protected]>
+
+ Remove dead code for reflected attributes from audio, video, and track elements
+ https://bugs.webkit.org/show_bug.cgi?id=125838
+
+ Reviewed by Eric Carlson.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/310514e2f0fd934975b841d463bad0cd62e6fd64
+
+ Where [Reflect] is used in the IDL, the getters and setters in C++ are
+ only for internal convenience, and these were unused.
+
+ * html/HTMLMediaElement.cpp:
+ * html/HTMLMediaElement.h:
+ * html/HTMLTrackElement.cpp:
+ * html/HTMLTrackElement.h:
+ * html/HTMLVideoElement.cpp:
+ * html/HTMLVideoElement.h:
+
2013-12-17 Simon Fraser <[email protected]>
Rename "canRubberBands" to "canRubberBand"
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (160746 => 160747)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2013-12-18 03:45:57 UTC (rev 160746)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2013-12-18 04:18:02 UTC (rev 160747)
@@ -2623,12 +2623,6 @@
return fastHasAttribute(autoplayAttr);
}
-void HTMLMediaElement::setAutoplay(bool b)
-{
- LOG(Media, "HTMLMediaElement::setAutoplay(%s)", boolString(b));
- setBooleanAttribute(autoplayAttr, b);
-}
-
String HTMLMediaElement::preload() const
{
switch (m_preload) {
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (160746 => 160747)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2013-12-18 03:45:57 UTC (rev 160746)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2013-12-18 04:18:02 UTC (rev 160747)
@@ -189,8 +189,7 @@
virtual PassRefPtr<TimeRanges> played() OVERRIDE;
virtual PassRefPtr<TimeRanges> seekable() const OVERRIDE;
bool ended() const;
- bool autoplay() const;
- void setAutoplay(bool b);
+ bool autoplay() const;
bool loop() const;
void setLoop(bool b);
virtual void play() OVERRIDE;
Modified: trunk/Source/WebCore/html/HTMLTrackElement.cpp (160746 => 160747)
--- trunk/Source/WebCore/html/HTMLTrackElement.cpp 2013-12-18 03:45:57 UTC (rev 160746)
+++ trunk/Source/WebCore/html/HTMLTrackElement.cpp 2013-12-18 04:18:02 UTC (rev 160747)
@@ -114,16 +114,6 @@
HTMLElement::parseAttribute(name, value);
}
-URL HTMLTrackElement::src() const
-{
- return document().completeURL(getAttribute(srcAttr));
-}
-
-void HTMLTrackElement::setSrc(const String& url)
-{
- setAttribute(srcAttr, url);
-}
-
String HTMLTrackElement::kind()
{
return track()->kind();
Modified: trunk/Source/WebCore/html/HTMLTrackElement.h (160746 => 160747)
--- trunk/Source/WebCore/html/HTMLTrackElement.h 2013-12-18 03:45:57 UTC (rev 160746)
+++ trunk/Source/WebCore/html/HTMLTrackElement.h 2013-12-18 04:18:02 UTC (rev 160747)
@@ -39,9 +39,6 @@
public:
static PassRefPtr<HTMLTrackElement> create(const QualifiedName&, Document&);
- URL src() const;
- void setSrc(const String&);
-
String kind();
void setKind(const String&);
Modified: trunk/Source/WebCore/html/HTMLVideoElement.cpp (160746 => 160747)
--- trunk/Source/WebCore/html/HTMLVideoElement.cpp 2013-12-18 03:45:57 UTC (rev 160746)
+++ trunk/Source/WebCore/html/HTMLVideoElement.cpp 2013-12-18 04:18:02 UTC (rev 160747)
@@ -191,20 +191,6 @@
return player()->naturalSize().height();
}
-unsigned HTMLVideoElement::width() const
-{
- bool ok;
- unsigned w = getAttribute(widthAttr).string().toUInt(&ok);
- return ok ? w : 0;
-}
-
-unsigned HTMLVideoElement::height() const
-{
- bool ok;
- unsigned h = getAttribute(heightAttr).string().toUInt(&ok);
- return ok ? h : 0;
-}
-
bool HTMLVideoElement::isURLAttribute(const Attribute& attribute) const
{
return attribute.name() == posterAttr || HTMLMediaElement::isURLAttribute(attribute);
Modified: trunk/Source/WebCore/html/HTMLVideoElement.h (160746 => 160747)
--- trunk/Source/WebCore/html/HTMLVideoElement.h 2013-12-18 03:45:57 UTC (rev 160746)
+++ trunk/Source/WebCore/html/HTMLVideoElement.h 2013-12-18 04:18:02 UTC (rev 160747)
@@ -37,9 +37,6 @@
public:
static PassRefPtr<HTMLVideoElement> create(const QualifiedName&, Document&, bool);
- unsigned width() const;
- unsigned height() const;
-
unsigned videoWidth() const;
unsigned videoHeight() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
