[webkit-changes] [160775] trunk/Source/WebCore

Wed, 18 Dec 2013 10:23:35 -0800

Title: [160775] trunk/Source/WebCore
Revision
160775
Author
[email protected]
Date
2013-12-18 10:26:09 -0800 (Wed, 18 Dec 2013)

Log Message

Remove JSInlineGetOwnPropertySlot attribute as it is no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=125875

Reviewed by Brady Eidson.

Tested this on dromaeo and acid3 (the original reason for this attribute)
and it no longer provided any benefit. This makes it easier to reason about
creation of getOwnPropertySlot during binding generation.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* dom/Document.idl:
* dom/Element.idl:
* dom/Node.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (160774 => 160775)


--- trunk/Source/WebCore/ChangeLog	2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/ChangeLog	2013-12-18 18:26:09 UTC (rev 160775)
@@ -1,3 +1,22 @@
+2013-12-17  Oliver Hunt  <[email protected]>
+
+        Remove JSInlineGetOwnPropertySlot attribute as it is no longer necessary
+        https://bugs.webkit.org/show_bug.cgi?id=125875
+
+        Reviewed by Brady Eidson.
+
+        Tested this on dromaeo and acid3 (the original reason for this attribute)
+        and it no longer provided any benefit. This makes it easier to reason about
+        creation of getOwnPropertySlot during binding generation.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateHeader):
+        (GenerateImplementation):
+        * bindings/scripts/IDLAttributes.txt:
+        * dom/Document.idl:
+        * dom/Element.idl:
+        * dom/Node.idl:
+
 2013-12-18  Tamas Gergely  <[email protected]>
 
         Fix ASSERTION FAILED in WebCore::SVGLengthContext::determineViewport

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (160774 => 160775)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2013-12-18 18:26:09 UTC (rev 160775)
@@ -588,10 +588,6 @@
         $headerIncludes{"<runtime/CallData.h>"} = 1;
     }
 
-    if ($interface->extendedAttributes->{"JSInlineGetOwnPropertySlot"}) {
-        $headerIncludes{"<runtime/Lookup.h>"} = 1;
-    }
-
     if ($hasParent && $interface->extendedAttributes->{"JSGenerateToNativeObject"}) {
         $headerIncludes{"$interfaceName.h"} = 1;
     }
@@ -913,15 +909,6 @@
 
     push(@headerContent, "};\n\n");
 
-    if ($interface->extendedAttributes->{"JSInlineGetOwnPropertySlot"} && !$interface->extendedAttributes->{"CustomGetOwnPropertySlot"}) {
-        push(@headerContent, "ALWAYS_INLINE bool ${className}::getOwnPropertySlot(JSC::JSObject* object, JSC::ExecState* exec, JSC::PropertyName propertyName, JSC::PropertySlot& slot)\n");
-        push(@headerContent, "{\n");
-        push(@headerContent, "    ${className}* thisObject = JSC::jsCast<${className}*>(object);\n");
-        push(@headerContent, "    ASSERT_GC_OBJECT_INHERITS(thisObject, info());\n");
-        push(@headerContent, GenerateGetOwnPropertySlotBody($interface, $interfaceName, $className, $numAttributes > 0, 1));
-        push(@headerContent, "}\n\n");
-    }
-
     if (!$hasParent ||
         GetGenerateIsReachable($interface) ||
         GetCustomIsReachable($interface) ||
@@ -1797,14 +1784,12 @@
     # Attributes
     if ($hasGetter) {
         if (!$interface->extendedAttributes->{"CustomGetOwnPropertySlot"}) {
-            if (!$interface->extendedAttributes->{"JSInlineGetOwnPropertySlot"}) {
-                push(@implContent, "bool ${className}::getOwnPropertySlot(JSObject* object, ExecState* exec, PropertyName propertyName, PropertySlot& slot)\n");
-                push(@implContent, "{\n");
-                push(@implContent, "    ${className}* thisObject = jsCast<${className}*>(object);\n");
-                push(@implContent, "    ASSERT_GC_OBJECT_INHERITS(thisObject, info());\n");
-                push(@implContent, GenerateGetOwnPropertySlotBody($interface, $interfaceName, $className, $numAttributes > 0, 0));
-                push(@implContent, "}\n\n");
-            }
+            push(@implContent, "bool ${className}::getOwnPropertySlot(JSObject* object, ExecState* exec, PropertyName propertyName, PropertySlot& slot)\n");
+            push(@implContent, "{\n");
+            push(@implContent, "    ${className}* thisObject = jsCast<${className}*>(object);\n");
+            push(@implContent, "    ASSERT_GC_OBJECT_INHERITS(thisObject, info());\n");
+            push(@implContent, GenerateGetOwnPropertySlotBody($interface, $interfaceName, $className, $numAttributes > 0, 0));
+            push(@implContent, "}\n\n");
         }
 
         if ($indexedGetterFunction || $namedGetterFunction

Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (160774 => 160775)


--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt	2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt	2013-12-18 18:26:09 UTC (rev 160775)
@@ -78,7 +78,6 @@
 JSCustomToNativeObject
 JSGenerateToJSObject
 JSGenerateToNativeObject
-JSInlineGetOwnPropertySlot
 JSLegacyParent=*
 JSNoStaticTables
 JSWindowEventListener

Modified: trunk/Source/WebCore/dom/Document.idl (160774 => 160775)


--- trunk/Source/WebCore/dom/Document.idl	2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/dom/Document.idl	2013-12-18 18:26:09 UTC (rev 160775)
@@ -21,7 +21,6 @@
 [
     CustomToJSObject,
     JSGenerateToNativeObject,
-    JSInlineGetOwnPropertySlot,
 ] interface Document : Node {
 
     // DOM Level 1 Core

Modified: trunk/Source/WebCore/dom/Element.idl (160774 => 160775)


--- trunk/Source/WebCore/dom/Element.idl	2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/dom/Element.idl	2013-12-18 18:26:09 UTC (rev 160775)
@@ -20,7 +20,6 @@
 
 [
     JSGenerateToNativeObject,
-    JSInlineGetOwnPropertySlot,
 ] interface Element : Node {
 
     // DOM Level 1 Core

Modified: trunk/Source/WebCore/dom/Node.idl (160774 => 160775)


--- trunk/Source/WebCore/dom/Node.idl	2013-12-18 18:14:12 UTC (rev 160774)
+++ trunk/Source/WebCore/dom/Node.idl	2013-12-18 18:26:09 UTC (rev 160775)
@@ -26,7 +26,6 @@
     CustomToJSObject,
     EventTarget,
     JSGenerateToNativeObject,
-    JSInlineGetOwnPropertySlot,
     ObjCPolymorphic,
 ] interface Node
 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to