- Revision
- 160900
- Author
- commit-qu...@webkit.org
- Date
- 2013-12-20 03:00:51 -0800 (Fri, 20 Dec 2013)
Log Message
Removed unused BUILDER_BASE_URL.
https://bugs.webkit.org/show_bug.cgi?id=125442
Patch by Peter Molnar <pmolnar.u-sze...@partner.samsung.com> on 2013-12-20
Reviewed by Csaba Osztrogonác.
The string constant BUILDER_BASE_URL is passed around several times,
but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._upload_json_files):
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.__init__):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGenerator.__init__):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (160899 => 160900)
--- trunk/Tools/ChangeLog 2013-12-20 10:52:32 UTC (rev 160899)
+++ trunk/Tools/ChangeLog 2013-12-20 11:00:51 UTC (rev 160900)
@@ -1,3 +1,20 @@
+2013-12-20 Peter Molnar <pmolnar.u-sze...@partner.samsung.com>
+
+ Removed unused BUILDER_BASE_URL.
+ https://bugs.webkit.org/show_bug.cgi?id=125442
+
+ Reviewed by Csaba Osztrogonác.
+
+ The string constant BUILDER_BASE_URL is passed around several times,
+ but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+ (Manager._upload_json_files):
+ * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
+ (JSONLayoutResultsGenerator.__init__):
+ * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
+ (JSONResultsGenerator.__init__):
+
2013-12-19 Myles C. Maxfield <mmaxfi...@apple.com>
check-webkit-style mistakenly flags assigning to a dereferenced pointer
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (160899 => 160900)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2013-12-20 10:52:32 UTC (rev 160899)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2013-12-20 11:00:51 UTC (rev 160900)
@@ -54,9 +54,6 @@
_log = logging.getLogger(__name__)
-# Builder base URL where we have the archived test results.
-BUILDER_BASE_URL = "http://build.chromium.org/buildbot/layout_test_results/"
-
TestExpectations = test_expectations.TestExpectations
@@ -356,7 +353,6 @@
generator = json_layout_results_generator.JSONLayoutResultsGenerator(
self._port, self._options.builder_name, self._options.build_name,
self._options.build_number, self._results_directory,
- BUILDER_BASE_URL,
self._expectations, initial_results,
self._options.test_results_server,
"layout-tests",
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py (160899 => 160900)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py 2013-12-20 10:52:32 UTC (rev 160899)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py 2013-12-20 11:00:51 UTC (rev 160900)
@@ -52,7 +52,7 @@
test_expectations.IMAGE_PLUS_TEXT: "Z"}
def __init__(self, port, builder_name, build_name, build_number,
- results_file_base_path, builder_base_url,
+ results_file_base_path,
expectations, run_results,
test_results_server=None, test_type="", master_name=""):
"""Modifies the results.json file. Grabs it off the archive directory
@@ -63,7 +63,7 @@
"""
super(JSONLayoutResultsGenerator, self).__init__(
port, builder_name, build_name, build_number, results_file_base_path,
- builder_base_url, {}, port.repository_paths(),
+ {}, port.repository_paths(),
test_results_server, test_type, master_name)
self._expectations = expectations
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py (160899 => 160900)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py 2013-12-20 10:52:32 UTC (rev 160899)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py 2013-12-20 11:00:51 UTC (rev 160900)
@@ -189,7 +189,7 @@
URL_FOR_TEST_LIST_JSON = "http://%s/testfile?builder=%s&name=%s&testlistjson=1&testtype=%s&master=%s"
def __init__(self, port, builder_name, build_name, build_number,
- results_file_base_path, builder_base_url,
+ results_file_base_path,
test_results_map, svn_repositories=None,
test_results_server=None,
test_type="",
@@ -204,8 +204,6 @@
build_number: the build number.
results_file_base_path: Absolute path to the directory containing the
results json file.
- builder_base_url: the URL where we have the archived test results.
- If this is None no archived results will be retrieved.
test_results_map: A dictionary that maps test_name to TestResult.
svn_repositories: A (json_field_name, svn_path) pair for SVN
repositories that tests rely on. The SVN revision will be
@@ -220,7 +218,6 @@
self._builder_name = builder_name
self._build_name = build_name
self._build_number = build_number
- self._builder_base_url = builder_base_url
self._results_directory = results_file_base_path
self._test_results_map = test_results_map
