Title: [160909] trunk/Source
- Revision
- 160909
- Author
- commit-qu...@webkit.org
- Date
- 2013-12-20 06:58:40 -0800 (Fri, 20 Dec 2013)
Log Message
[GTK] The fullscreen API should be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=125993
Patch by Enrique Ocaña González <eoca...@igalia.com> on 2013-12-20
Reviewed by Gustavo Noronha Silva.
Set the WebSettings property to TRUE
Source/WebKit/gtk:
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
Source/WebKit2:
* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_class_init):
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (160908 => 160909)
--- trunk/Source/WebKit/gtk/ChangeLog 2013-12-20 14:44:23 UTC (rev 160908)
+++ trunk/Source/WebKit/gtk/ChangeLog 2013-12-20 14:58:40 UTC (rev 160909)
@@ -1,3 +1,15 @@
+2013-12-20 Enrique Ocaña González <eoca...@igalia.com>
+
+ [GTK] The fullscreen API should be enabled by default
+ https://bugs.webkit.org/show_bug.cgi?id=125993
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Set the WebSettings property to TRUE
+
+ * webkit/webkitwebsettings.cpp:
+ (webkit_web_settings_class_init):
+
2013-12-16 Martin Robinson <mrobin...@igalia.com>
[GTK] [CMake] Add support for building WebKit1
Modified: trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp (160908 => 160909)
--- trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp 2013-12-20 14:44:23 UTC (rev 160908)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp 2013-12-20 14:58:40 UTC (rev 160909)
@@ -826,14 +826,25 @@
FALSE,
flags));
- /* Undocumented for now */
+ /**
+ * WebKitWebSettings:enable-fullscreen:
+ *
+ *
+ * Whether to enable the _javascript_ Fullscreen API. The API
+ * allows any HTML element to request fullscreen display. See also
+ * the current draft of the spec:
+ * http://www.w3.org/TR/fullscreen/
+ *
+ * Since: 2.4
+ */
g_object_class_install_property(gobject_class,
- PROP_ENABLE_FULLSCREEN,
- g_param_spec_boolean("enable-fullscreen",
- _("Enable Fullscreen"),
- _("Whether the Mozilla style API should be enabled."),
- FALSE,
- flags));
+ PROP_ENABLE_FULLSCREEN,
+ g_param_spec_boolean("enable-fullscreen",
+ _("Enable Fullscreen"),
+ _("Whether to enable the _javascript_ Fullscreen API"),
+ TRUE,
+ flags));
+
/**
* WebKitWebSettings:enable-webgl:
*
Modified: trunk/Source/WebKit2/ChangeLog (160908 => 160909)
--- trunk/Source/WebKit2/ChangeLog 2013-12-20 14:44:23 UTC (rev 160908)
+++ trunk/Source/WebKit2/ChangeLog 2013-12-20 14:58:40 UTC (rev 160909)
@@ -1,3 +1,15 @@
+2013-12-20 Enrique Ocaña González <eoca...@igalia.com>
+
+ [GTK] The fullscreen API should be enabled by default
+ https://bugs.webkit.org/show_bug.cgi?id=125993
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Set the WebSettings property to TRUE
+
+ * UIProcess/API/gtk/WebKitSettings.cpp:
+ (webkit_settings_class_init):
+
2013-12-20 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] Some unit tests using web extensions fail when run alone
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (160908 => 160909)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2013-12-20 14:44:23 UTC (rev 160908)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2013-12-20 14:58:40 UTC (rev 160909)
@@ -898,15 +898,15 @@
* Whether to enable the _javascript_ Fullscreen API. The API
* allows any HTML element to request fullscreen display. See also
* the current draft of the spec:
- * http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html
+ * http://www.w3.org/TR/fullscreen/
*/
g_object_class_install_property(gObjectClass,
- PROP_ENABLE_FULLSCREEN,
- g_param_spec_boolean("enable-fullscreen",
- _("Enable Fullscreen"),
- _("Whether to enable the Javascriipt Fullscreen API"),
- FALSE,
- readWriteConstructParamFlags));
+ PROP_ENABLE_FULLSCREEN,
+ g_param_spec_boolean("enable-fullscreen",
+ _("Enable Fullscreen"),
+ _("Whether to enable the _javascript_ Fullscreen API"),
+ TRUE,
+ readWriteConstructParamFlags));
/**
* WebKitSettings:print-backgrounds:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
