Title: [161014] trunk/Source/WebCore
- Revision
- 161014
- Author
- [email protected]
- Date
- 2013-12-23 13:39:23 -0800 (Mon, 23 Dec 2013)
Log Message
Clear ScratchBuffer::m_lastLayerSize when clearing the scratch buffer.
https://bugs.webkit.org/show_bug.cgi?id=126150
Reviewed by Simon Fraser.
Since ScratchBuffer::clearScratchBuffer only clears m_lastRadius,
ShadowBlur doesn't draw shadow into the re-created scratch buffer if it
tries to draw shadow without blurRadius.
Clear m_lastLayerSize to empty is enought to ensure that there is no
drawn contents in the scratch buffer.
No new tests due to the flaky nature of reproducing the issue.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::clearScratchBuffer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161013 => 161014)
--- trunk/Source/WebCore/ChangeLog 2013-12-23 21:09:44 UTC (rev 161013)
+++ trunk/Source/WebCore/ChangeLog 2013-12-23 21:39:23 UTC (rev 161014)
@@ -1,3 +1,22 @@
+2013-12-23 Gwang Yoon Hwang <[email protected]>
+
+ Clear ScratchBuffer::m_lastLayerSize when clearing the scratch buffer.
+ https://bugs.webkit.org/show_bug.cgi?id=126150
+
+ Reviewed by Simon Fraser.
+
+ Since ScratchBuffer::clearScratchBuffer only clears m_lastRadius,
+ ShadowBlur doesn't draw shadow into the re-created scratch buffer if it
+ tries to draw shadow without blurRadius.
+
+ Clear m_lastLayerSize to empty is enought to ensure that there is no
+ drawn contents in the scratch buffer.
+
+ No new tests due to the flaky nature of reproducing the issue.
+
+ * platform/graphics/ShadowBlur.cpp:
+ (WebCore::ScratchBuffer::clearScratchBuffer):
+
2013-12-23 Benjamin Poulain <[email protected]>
Add id matching to the Selector Code Generator
Modified: trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp (161013 => 161014)
--- trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp 2013-12-23 21:09:44 UTC (rev 161013)
+++ trunk/Source/WebCore/platform/graphics/ShadowBlur.cpp 2013-12-23 21:39:23 UTC (rev 161014)
@@ -139,6 +139,7 @@
{
m_imageBuffer = nullptr;
m_lastRadius = FloatSize();
+ m_lastLayerSize = FloatSize();
}
std::unique_ptr<ImageBuffer> m_imageBuffer;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
