Title: [161026] trunk/Source/WebCore
- Revision
- 161026
- Author
- [email protected]
- Date
- 2013-12-23 15:13:21 -0800 (Mon, 23 Dec 2013)
Log Message
Minor optimization in FrameSelection::setNonDirectionalSelectionIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=126108
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/237b987c324e2e389a9e0350293bfaf16a5e201d
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161025 => 161026)
--- trunk/Source/WebCore/ChangeLog 2013-12-23 23:04:13 UTC (rev 161025)
+++ trunk/Source/WebCore/ChangeLog 2013-12-23 23:13:21 UTC (rev 161026)
@@ -1,5 +1,17 @@
2013-12-23 Ryosuke Niwa <[email protected]>
+ Minor optimization in FrameSelection::setNonDirectionalSelectionIfNeeded()
+ https://bugs.webkit.org/show_bug.cgi?id=126108
+
+ Reviewed by Benjamin Poulain.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/237b987c324e2e389a9e0350293bfaf16a5e201d
+
+ * editing/FrameSelection.cpp:
+ (WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):
+
+2013-12-23 Ryosuke Niwa <[email protected]>
+
Use isDocumentFragment() instead of comparing nodeType() with Node::DOCUMENT_FRAGMENT_NODE
https://bugs.webkit.org/show_bug.cgi?id=126178
Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (161025 => 161026)
--- trunk/Source/WebCore/editing/FrameSelection.cpp 2013-12-23 23:04:13 UTC (rev 161025)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp 2013-12-23 23:13:21 UTC (rev 161026)
@@ -213,11 +213,12 @@
VisiblePosition base = m_originalBase.isNotNull() ? m_originalBase : newSelection.visibleBase();
VisiblePosition newBase = base;
- VisiblePosition newExtent = newSelection.visibleExtent();
+ VisiblePosition extent = newSelection.visibleExtent();
+ VisiblePosition newExtent = extent;
if (endpointsAdjustmentMode == AdjustEndpointsAtBidiBoundary)
adjustEndpointsAtBidiBoundary(newBase, newExtent);
- if (newBase != base || newExtent != newSelection.visibleExtent()) {
+ if (newBase != base || newExtent != extent) {
m_originalBase = base;
newSelection.setBase(newBase);
newSelection.setExtent(newExtent);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
