Title: [161057] branches/jsCStack/Source/_javascript_Core
- Revision
- 161057
- Author
- [email protected]
- Date
- 2013-12-24 07:32:19 -0800 (Tue, 24 Dec 2013)
Log Message
CStack Branch: throwExceptionFromCallSlowPathGenerator() shouldn't pop frame
https://bugs.webkit.org/show_bug.cgi?id=126204
Reviewed by Filip Pizlo.
Given that the function epilogue pops the callee frame, there is no need
to pop a frame in throwExceptionFromCallSlowPathGenerator().
* jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator):
Modified Paths
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161056 => 161057)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2013-12-24 14:45:37 UTC (rev 161056)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2013-12-24 15:32:19 UTC (rev 161057)
@@ -1,3 +1,16 @@
+2013-12-23 Michael Saboff <[email protected]>
+
+ CStack Branch: throwExceptionFromCallSlowPathGenerator() shouldn't pop frame
+ https://bugs.webkit.org/show_bug.cgi?id=126204
+
+ Reviewed by Filip Pizlo.
+
+ Given that the function epilogue pops the callee frame, there is no need
+ to pop a frame in throwExceptionFromCallSlowPathGenerator().
+
+ * jit/ThunkGenerators.cpp:
+ (JSC::throwExceptionFromCallSlowPathGenerator):
+
2013-12-23 Mark Lam <[email protected]>
CStack:Fixed JSStack::disableErrorStackReserve() and JSStack::installTrapsAfterFrame().
Modified: branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp (161056 => 161057)
--- branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp 2013-12-24 14:45:37 UTC (rev 161056)
+++ branches/jsCStack/Source/_javascript_Core/jit/ThunkGenerators.cpp 2013-12-24 15:32:19 UTC (rev 161057)
@@ -66,9 +66,6 @@
// even though we won't use it.
jit.preserveReturnAddressAfterCall(GPRInfo::nonPreservedNonReturnGPR);
- // The CallFrame register points to the (failed) callee frame, so we need to pop back one frame.
- jit.emitGetCallerFrameFromCallFrameHeaderPtr(GPRInfo::callFrameRegister);
-
jit.setupArgumentsExecState();
jit.move(CCallHelpers::TrustedImmPtr(bitwise_cast<void*>(lookupExceptionHandler)), GPRInfo::nonArgGPR0);
emitPointerValidation(jit, GPRInfo::nonArgGPR0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
