Title: [161078] trunk/Tools
- Revision
- 161078
- Author
- [email protected]
- Date
- 2013-12-25 16:33:36 -0800 (Wed, 25 Dec 2013)
Log Message
Revision selection behavior at build.webkit.org/dashboard is annoying
https://bugs.webkit.org/show_bug.cgi?id=126235
Reviewed by Tim Horton.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
selectable, not just the numbers in it.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(.selectable): Make selectable enable default behavior, not user-select:all.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (161077 => 161078)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2013-12-26 00:29:42 UTC (rev 161077)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2013-12-26 00:33:36 UTC (rev 161078)
@@ -88,13 +88,9 @@
var linkElement = document.createElement("a");
linkElement.href = "" internal);
linkElement.target = "_blank";
- linkElement.textContent = "r";
+ linkElement.textContent = "r" + revision;
+ linkElement.classList.add("selectable");
- var revisionLabel = document.createElement("span");
- revisionLabel.classList.add("selectable");
- revisionLabel.textContent = revision;
- linkElement.appendChild(revisionLabel);
-
return linkElement;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (161077 => 161078)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-12-26 00:29:42 UTC (rev 161077)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-12-26 00:33:36 UTC (rev 161078)
@@ -35,7 +35,7 @@
}
.selectable {
- -webkit-user-select: all;
+ -webkit-user-select: auto;
}
div.cellButton {
Modified: trunk/Tools/ChangeLog (161077 => 161078)
--- trunk/Tools/ChangeLog 2013-12-26 00:29:42 UTC (rev 161077)
+++ trunk/Tools/ChangeLog 2013-12-26 00:33:36 UTC (rev 161078)
@@ -1,3 +1,16 @@
+2013-12-25 Alexey Proskuryakov <[email protected]>
+
+ Revision selection behavior at build.webkit.org/dashboard is annoying
+ https://bugs.webkit.org/show_bug.cgi?id=126235
+
+ Reviewed by Tim Horton.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
+ selectable, not just the numbers in it.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ (.selectable): Make selectable enable default behavior, not user-select:all.
+
2013-12-25 Martin Robinson <[email protected]>
[GTK] [CMake] Clean up generated sources directories
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
