Title: [161089] trunk/Source/WebCore
- Revision
- 161089
- Author
- [email protected]
- Date
- 2013-12-26 10:00:39 -0800 (Thu, 26 Dec 2013)
Log Message
Make Text::createTextRenderer() take a const RenderStyle&.
<https://webkit.org/b/126136>
Nuke a FIXME about constifying a RenderStyle& local.
Reviewed by Anders Carlsson.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (161088 => 161089)
--- trunk/Source/WebCore/ChangeLog 2013-12-26 17:58:56 UTC (rev 161088)
+++ trunk/Source/WebCore/ChangeLog 2013-12-26 18:00:39 UTC (rev 161089)
@@ -1,5 +1,14 @@
2013-12-22 Andreas Kling <[email protected]>
+ Make Text::createTextRenderer() take a const RenderStyle&.
+ <https://webkit.org/b/126136>
+
+ Nuke a FIXME about constifying a RenderStyle& local.
+
+ Reviewed by Anders Carlsson.
+
+2013-12-22 Andreas Kling <[email protected]>
+
Move more inlines from RenderObject to RenderElement.
<https://webkit.org/b/126134>
Modified: trunk/Source/WebCore/dom/Text.cpp (161088 => 161089)
--- trunk/Source/WebCore/dom/Text.cpp 2013-12-26 17:58:56 UTC (rev 161088)
+++ trunk/Source/WebCore/dom/Text.cpp 2013-12-26 18:00:39 UTC (rev 161089)
@@ -187,7 +187,7 @@
}
#endif
-RenderText* Text::createTextRenderer(RenderStyle& style)
+RenderText* Text::createTextRenderer(const RenderStyle& style)
{
#if ENABLE(SVG)
if (isSVGText(this) || isSVGShadowText(this))
Modified: trunk/Source/WebCore/dom/Text.h (161088 => 161089)
--- trunk/Source/WebCore/dom/Text.h 2013-12-26 17:58:56 UTC (rev 161088)
+++ trunk/Source/WebCore/dom/Text.h 2013-12-26 18:00:39 UTC (rev 161089)
@@ -47,7 +47,7 @@
String wholeText() const;
PassRefPtr<Text> replaceWholeText(const String&, ExceptionCode&);
- RenderText* createTextRenderer(RenderStyle&);
+ RenderText* createTextRenderer(const RenderStyle&);
virtual bool canContainRangeEndPoint() const OVERRIDE FINAL { return true; }
Modified: trunk/Source/WebCore/style/StyleResolveTree.cpp (161088 => 161089)
--- trunk/Source/WebCore/style/StyleResolveTree.cpp 2013-12-26 17:58:56 UTC (rev 161088)
+++ trunk/Source/WebCore/style/StyleResolveTree.cpp 2013-12-26 18:00:39 UTC (rev 161089)
@@ -378,8 +378,7 @@
if (!renderingParentNode->childShouldCreateRenderer(textNode))
return;
- // FIXME: constify this RenderStyle&.
- RenderStyle& style = parentRenderer->style();
+ const auto& style = parentRenderer->style();
if (!textRendererIsNeeded(textNode, *parentRenderer, style))
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
