Title: [161092] trunk/Tools
- Revision
- 161092
- Author
- [email protected]
- Date
- 2013-12-26 11:20:22 -0800 (Thu, 26 Dec 2013)
Log Message
Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=126234
Reviewed by Timothy Hatcher.
Changed elements that are semantically links from <div> to <a>.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
Don't try simulate a link with CSS/JS, it's not needed any more.
(StatusLineView.prototype._clicked): Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
Removed text-decoration rules, default ones in Main.css now work for queue elements.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
Simplified cursor rules.
Added a universal rule for links to only show underline on hover, as this is what
we want almost everywhere.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line .bubble): Added text-decoration: none, as this is the one place where
we don't want it even on hover.
(.status-line .label): Force display: block for consistent layout between <a>
and <div>.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js (161091 => 161092)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js 2013-12-26 19:20:22 UTC (rev 161092)
@@ -33,12 +33,22 @@
this.element.classList.add("status-line");
this.element.__statusLineView = this;
- this._statusBubbleElement = document.createElement("div");
+ if (url) {
+ this._statusBubbleElement = document.createElement("a");
+ this._statusBubbleElement.href = ""
+ this._statusBubbleElement.target = "_blank";
+ } else
+ this._statusBubbleElement = document.createElement("div");
this._statusBubbleElement.classList.add("bubble");
if (status != StatusLineView.Status.NoBubble)
this.element.appendChild(this._statusBubbleElement);
- this._labelElement = document.createElement("div");
+ if (url) {
+ this._labelElement = document.createElement("a");
+ this._labelElement.href = ""
+ this._labelElement.target = "_blank";
+ } else
+ this._labelElement = document.createElement("div");
this._labelElement.classList.add("label");
this._messageElement = document.createElement("div");
@@ -50,11 +60,6 @@
this.label = label || "";
this.repeatCount = repeatCount || 0;
this.url = "" || null;
-
- if (url) {
- this.element.addEventListener("click", this._clicked.bind(this));
- this.element.classList.add("linked");
- }
};
StatusLineView.Status = {
@@ -155,17 +160,5 @@
} else {
this._messageElement.textContent = x;
}
- },
-
- _clicked: function(event)
- {
- if (!this.url)
- return;
-
- var anchor = document.createElement("a");
- anchor.href = ""
- anchor.target = "_blank";
-
- anchor.click();
}
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css (161091 => 161092)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css 2013-12-26 19:20:22 UTC (rev 161092)
@@ -34,13 +34,8 @@
font-family: "HelveticaNeue-Light", "Helvetica Neue", sans-serif;
color: rgb(145, 135, 95);
text-align: left;
- text-decoration: none;
}
-.queue-view .queueLabel:hover {
- text-decoration: underline;
-}
-
.queue-view .queueLabel:not(:first-child) {
margin-top: 10px;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (161091 => 161092)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-12-26 19:20:22 UTC (rev 161092)
@@ -25,15 +25,18 @@
* {
box-sizing: border-box;
- cursor: default;
-webkit-user-select: none;
-webkit-user-drag: none;
}
-a:link {
- cursor: pointer;
+a {
+ text-decoration: none;
}
+a:hover {
+ text-decoration: underline;
+}
+
.selectable {
-webkit-user-select: auto;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css (161091 => 161092)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css 2013-12-26 19:20:22 UTC (rev 161092)
@@ -29,11 +29,6 @@
padding: 2px 0;
}
-.status-line.linked,
-.status-line.linked * {
- cursor: pointer;
-}
-
.status-line .bubble {
float: left;
min-width: 24px;
@@ -48,6 +43,7 @@
overflow: hidden;
margin-top: 2px;
margin-right: 6px;
+ text-decoration: none;
}
.status-line.neutral .bubble {
@@ -92,6 +88,7 @@
text-transform: lowercase;
line-height: 11px;
padding-top: 1px;
+ display: block;
}
.status-line .message {
@@ -104,14 +101,6 @@
color: inherit;
}
-.status-line .message a:link {
- text-decoration: none;
-}
-
-.status-line .message a:link:hover {
- text-decoration: underline;
-}
-
.status-line.no-label .message {
line-height: 28px;
}
@@ -141,7 +130,3 @@
.status-line.bad .message {
color: rgb(191, 67, 41);
}
-
-.status-line.linked .label:hover {
- text-decoration: underline;
-}
\ No newline at end of file
Modified: trunk/Tools/ChangeLog (161091 => 161092)
--- trunk/Tools/ChangeLog 2013-12-26 18:19:20 UTC (rev 161091)
+++ trunk/Tools/ChangeLog 2013-12-26 19:20:22 UTC (rev 161092)
@@ -1,3 +1,31 @@
+2013-12-26 Alexey Proskuryakov <[email protected]>
+
+ Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
+ https://bugs.webkit.org/show_bug.cgi?id=126234
+
+ Reviewed by Timothy Hatcher.
+
+ Changed elements that are semantically links from <div> to <a>.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
+ (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
+ Don't try simulate a link with CSS/JS, it's not needed any more.
+ (StatusLineView.prototype._clicked): Removed.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
+ Removed text-decoration rules, default ones in Main.css now work for queue elements.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ Simplified cursor rules.
+ Added a universal rule for links to only show underline on hover, as this is what
+ we want almost everywhere.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
+ (.status-line .bubble): Added text-decoration: none, as this is the one place where
+ we don't want it even on hover.
+ (.status-line .label): Force display: block for consistent layout between <a>
+ and <div>.
+
2013-12-25 Alexey Proskuryakov <[email protected]>
Please clarify "pending" reporting at build.webkit.org/dashboard
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
